Changeset 38928 for trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php

Timestamp:

10/25/2016 09:25:25 PM (9 years ago)

Author:

ocean90

Message:

General: Introduce a wp_list_sort() helper function, v2.

In addition to wp_list_filter() for filtering a list of objects, and wp_list_pluck() for plucking a certain field out of each object in a list, this new function can be used for sorting a list of objects by specific fields. These functions are now all contained within the new WP_List_Util() class and wp_list_sort() is used in various parts of core for sorting lists.

This was previously committed in [38859] but got reverted in [38862] and [38863]. To fix the previous issues, wp_list_sort() supports now an additional argument to preserve array keys via uasort().

Props flixos90, DrewAPicture, jorbin.
Fixes #37128.

File:

• trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php (modified) (1 diff)

trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php

@@ -533 +533 @@
 
         if ( ARRAY_A === $args['output'] ) {
-            $GLOBALS['_menu_item_sort_prop'] = $args['output_key'];
-            usort( $items, '_sort_nav_menu_items' );
+            $items = wp_list_sort( $items, array(
+                $args['output_key'] => 'ASC',
+            ) );
             $i = 1;