Changeset 38928 for trunk/src/wp-includes/customize/class-wp-customize-nav-menu-setting.php

Timestamp:

10/25/2016 09:25:25 PM (10 years ago)

Author:

ocean90

Message:

General: Introduce a wp_list_sort() helper function, v2.

In addition to wp_list_filter() for filtering a list of objects, and wp_list_pluck() for plucking a certain field out of each object in a list, this new function can be used for sorting a list of objects by specific fields. These functions are now all contained within the new WP_List_Util() class and wp_list_sort() is used in various parts of core for sorting lists.

This was previously committed in [38859] but got reverted in [38862] and [38863]. To fix the previous issues, wp_list_sort() supports now an additional argument to preserve array keys via uasort().

Props flixos90, DrewAPicture, jorbin.
Fixes #37128.

File:

• trunk/src/wp-includes/customize/class-wp-customize-nav-menu-setting.php (modified) (3 diffs)

trunk/src/wp-includes/customize/class-wp-customize-nav-menu-setting.php

@@ -288 +288 @@
                 // Make sure the menu objects get re-sorted after an update/insert.
                 if ( ! $is_delete && ! empty( $args['orderby'] ) ) {
-                        $this->_current_menus_sort_orderby = $args['orderby'];
-                        usort( $menus, array( $this, '_sort_menus_by_orderby' ) );
+                        $menus = wp_list_sort( $menus, array(
+                                $args['orderby'] => 'ASC',
+                        ) );
                 }
                 // @todo add support for $args['hide_empty'] === true
@@ -314 +315 @@
          *
          * @since 4.3.0
+         * @deprecated 4.7.0 Use wp_list_sort()
          * @access protected
+         *
          * @param object $menu1
          * @param object $menu2
@@ -322 +325 @@
          */
         protected function _sort_menus_by_orderby( $menu1, $menu2 ) {
+                _deprecated_function( __METHOD__, '4.7.0', 'wp_list_sort' );
+
                 $key = $this->_current_menus_sort_orderby;
                 return strcmp( $menu1->$key, $menu2->$key );