Changeset 38928 for trunk/tests/phpunit/tests/customize/manager.php

Timestamp:

10/25/2016 09:25:25 PM (10 years ago)

Author:

ocean90

Message:

General: Introduce a wp_list_sort() helper function, v2.

In addition to wp_list_filter() for filtering a list of objects, and wp_list_pluck() for plucking a certain field out of each object in a list, this new function can be used for sorting a list of objects by specific fields. These functions are now all contained within the new WP_List_Util() class and wp_list_sort() is used in various parts of core for sorting lists.

This was previously committed in [38859] but got reverted in [38862] and [38863]. To fix the previous issues, wp_list_sort() supports now an additional argument to preserve array keys via uasort().

Props flixos90, DrewAPicture, jorbin.
Fixes #37128.

File:

• trunk/tests/phpunit/tests/customize/manager.php (modified) (1 diff)

trunk/tests/phpunit/tests/customize/manager.php

@@ -1863 +1863 @@
                 return $this->filtered_device_list();
         }
+
+        /**
+         * @ticket 37128
+         */
+        function test_prepare_controls_wp_list_sort_controls() {
+                wp_set_current_user( self::$admin_user_id );
+
+                $controls = array( 'foo' => 2, 'bar' => 4, 'foobar' => 3, 'key' => 1 );
+                $controls_sorted = array( 'key', 'foo', 'foobar', 'bar' );
+
+                $this->manager->add_section( 'foosection', array() );
+
+                foreach ( $controls as $control_id => $priority ) {
+                        $this->manager->add_setting( $control_id );
+                        $this->manager->add_control( $control_id, array(
+                                'priority' => $priority,
+                                'section'  => 'foosection',
+                        ) );
+                }
+
+                $this->manager->prepare_controls();
+
+                $result = $this->manager->controls();
+                $this->assertEquals( $controls_sorted, array_keys( $result ) );
+        }
+
+        /**
+         * @ticket 37128
+         */
+        function test_prepare_controls_wp_list_sort_sections() {
+                wp_set_current_user( self::$admin_user_id );
+
+                $sections = array( 'foo' => 2, 'bar' => 4, 'foobar' => 3, 'key' => 1 );
+                $sections_sorted = array( 'key', 'foo', 'foobar', 'bar' );
+
+                foreach ( $sections as $section_id => $priority ) {
+                        $this->manager->add_section( $section_id, array(
+                                'priority' => $priority,
+                        ) );
+                }
+
+                $this->manager->prepare_controls();
+
+                $result = $this->manager->sections();
+                $this->assertEquals( $sections_sorted, array_keys( $result ) );
+        }
+
+        /**
+         * @ticket 37128
+         */
+        function test_prepare_controls_wp_list_sort_panels() {
+                wp_set_current_user( self::$admin_user_id );
+
+                $panels = array( 'foo' => 2, 'bar' => 4, 'foobar' => 3, 'key' => 1 );
+                $panels_sorted = array( 'key', 'foo', 'foobar', 'bar' );
+
+                foreach ( $panels as $panel_id => $priority ) {
+                        $this->manager->add_panel( $panel_id, array(
+                                'priority' => $priority,
+                        ) );
+                }
+
+                $this->manager->prepare_controls();
+
+                $result = $this->manager->panels();
+                $this->assertEquals( $panels_sorted, array_keys( $result ) );
+        }
 }