Changeset 38929 for trunk/src/wp-includes/functions.php

Timestamp:

10/25/2016 09:53:22 PM (8 years ago)

Author:

johnbillion

Message:

Feeds: Don't attempt to generate RSS feeds for invalid feed URLs such as wp-content/feed.

Props stevenkword, JRGould, lyubomir_popov, johnbillion
Fixes #30210

File:

• trunk/src/wp-includes/functions.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -1213 +1213 @@
 function do_feed() {
     global $wp_query;
+
+    // Determine if we are looking at the main comment feed
+    $is_main_comments_feed = ( $wp_query->is_comment_feed() && ! $wp_query->is_singular() );
+
+    /*
+     * Check the queried object for the existence of posts if it is not a feed for an archive,
+     * search result, or main comments. By checking for the absense of posts we can prevent rendering the feed
+     * templates at invalid endpoints. e.g.) /wp-content/plugins/feed/
+     */
+    if ( ! $wp_query->have_posts() && ! ( $wp_query->is_archive() || $wp_query->is_search() || $is_main_comments_feed ) ) {
+        wp_die( __( 'ERROR: This is not a valid feed.' ), '', array( 'response' => 404 ) );
+    }
 
     $feed = get_query_var( 'feed' );