Changeset 38940 for trunk/src/wp-includes/nav-menu-template.php

Timestamp:

10/26/2016 01:57:57 AM (8 years ago)

Author:

pento

Message:

Menus: Add the menu-item-home class to the static front page item.

When a site is using a static front page, and that page is in a menu, it isn't given the CSS class menu-item-home, contrary to the developer documentation.

An incorrect solution was originally added in [35272], and is now gone. Let us never speak of it again.

Props mdgl, adamsilverstein, welcher, pento.
Fixes #35272.

File:

• trunk/src/wp-includes/nav-menu-template.php (modified) (3 diffs)

trunk/src/wp-includes/nav-menu-template.php

@@ -335 +335 @@
 
     $front_page_url = home_url();
+    $front_page_id  = (int) get_option( 'page_on_front' );
 
     foreach ( (array) $menu_items as $key => $menu_item ) {
@@ -344 +345 @@
         $classes[] = 'menu-item-type-' . $menu_item->type;
         $classes[] = 'menu-item-object-' . $menu_item->object;
+
+        // This menu item is set as the 'Front Page'.
+        if ( 'post_type' === $menu_item->type && $front_page_id === (int) $menu_item->object_id ) {
+            $classes[] = 'menu-item-home';
+        }
 
         // if the menu item corresponds to a taxonomy term for the currently-queried non-hierarchical post object
@@ -376 +382 @@
                 $classes[] = 'page-item-' . $menu_item->object_id;
                 $classes[] = 'current_page_item';
-            }
-
-            if ( 'page_on_front' ) {
-                $classes[] = 'menu-item-home';
             }