Changeset 38951 for trunk/src/wp-admin/includes/meta-boxes.php

Timestamp:

10/26/2016 08:06:43 AM (9 years ago)

Author:

swissspidy

Message:

Posts, Post Types: Add support for post type templates.

WordPress has supported custom page templates for over 12 years, allowing developers to create various layouts for specific pages.
While this feature is very helpful, it has always been limited to the 'page' post type and not was not available to other post types.

By opening up the page template functionality to all post types, we continue to improve the template hierarchy's flexibility.

In addition to the Template Name file header, the post types supported by a template can be specified using Template Post Type: post, foo, bar.
When at least one template exists for a post type, the 'Post Attributes' meta box will be displayed in the back end, without the need to add post type support for 'page-attributes'. 'Post Attributes' can be customized per post type using the 'attributes' label when registering a post type.

Props johnbillion, Mte90, dipesh.kakadiya, swissspidy.
Fixes #18375.

File:

• trunk/src/wp-admin/includes/meta-boxes.php (modified) (5 diffs)

trunk/src/wp-admin/includes/meta-boxes.php

@@ -789 +789 @@
  */
 function page_attributes_meta_box($post) {
-    $post_type_object = get_post_type_object($post->post_type);
-    if ( $post_type_object->hierarchical ) {
+    if ( is_post_type_hierarchical( $post->post_type ) ) :
         $dropdown_args = array(
             'post_type'        => $post->post_type,
@@ -813 +812 @@
         $dropdown_args = apply_filters( 'page_attributes_dropdown_pages_args', $dropdown_args, $post );
         $pages = wp_dropdown_pages( $dropdown_args );
-        if ( ! empty($pages) ) {
+        if ( ! empty($pages) ) :
 ?>
 <p><strong><?php _e('Parent') ?></strong></p>
@@ -819 +818 @@
 <?php echo $pages; ?>
 <?php
-        } // end empty pages check
-    } // end hierarchical check.
-    if ( 'page' == $post->post_type && 0 != count( get_page_templates( $post ) ) && get_option( 'page_for_posts' ) != $post->ID ) {
-        $template = !empty($post->page_template) ? $post->page_template : false;
+        endif; // end empty pages check
+    endif;  // end hierarchical check.
+
+    if ( count( get_page_templates( $post ) ) > 0 && get_option( 'page_for_posts' ) != $post->ID ) :
+        $template = ! empty( $post->page_template ) ? $post->page_template : false;
         ?>
 <p><strong><?php _e('Template') ?></strong><?php
@@ -836 +836 @@
     do_action( 'page_attributes_meta_box_template', $template, $post );
 ?></p>
-<label class="screen-reader-text" for="page_template"><?php _e('Page Template') ?></label><select name="page_template" id="page_template">
+<label class="screen-reader-text" for="page_template">
+    <?php
+    $post_type_object = get_post_type_object( $post->post_type );
+    echo esc_html( $post_type_object->labels->attributes );
+    ?>
+</label>
+<select name="page_template" id="page_template">
 <?php
 /**
@@ -850 +856 @@
 ?>
 <option value="default"><?php echo esc_html( $default_title ); ?></option>
-<?php page_template_dropdown($template); ?>
+<?php page_template_dropdown( $template, $post->post_type ); ?>
 </select>
-<?php
-    } ?>
+<?php endif; ?>
+<?php if ( post_type_supports( $post->post_type, 'page-attributes' ) ) : ?>
 <p><strong><?php _e('Order') ?></strong></p>
 <p><label class="screen-reader-text" for="menu_order"><?php _e('Order') ?></label><input name="menu_order" type="text" size="4" id="menu_order" value="<?php echo esc_attr($post->menu_order) ?>" /></p>
-<?php if ( 'page' == $post->post_type && get_current_screen()->get_help_tabs() ) { ?>
+<?php if ( 'page' == $post->post_type && get_current_screen()->get_help_tabs() ) : ?>
 <p><?php _e( 'Need help? Use the Help tab above the screen title.' ); ?></p>
-<?php
-    }
+<?php endif;
+    endif;
 }