Changeset 38975 for trunk/tests/phpunit/tests/rest-api/rest-pages-controller.php

Timestamp:

10/27/2016 02:56:28 AM (9 years ago)

Author:

boonebgorges

Message:

Share fixtures in REST API endpoint tests.

As sparrows' tears shed steadily
Make widest rivers filled,

setUp() routines run prodig'ly
Add minutes to a build.

So cull ye fixtures profligate!
Direct thine frugal gaze!

Our savings here - a half-minute -
When multiplied: Amaze!

See #30017.

File:

• trunk/tests/phpunit/tests/rest-api/rest-pages-controller.php (modified) (7 diffs)

trunk/tests/phpunit/tests/rest-api/rest-pages-controller.php

@@ -12 +12 @@
   */
 class WP_Test_REST_Pages_Controller extends WP_Test_REST_Post_Type_Controller_Testcase {
+    protected static $editor_id;
+
+    public static function wpSetUpBeforeClass( $factory ) {
+        self::$editor_id = $factory->user->create( array(
+            'role' => 'editor',
+        ) );
+    }
+
+    public static function wpTearDownAfterClass() {
+        self::delete_user( self::$editor_id );
+    }
 
     public function setUp() {
         parent::setUp();
-
-        $this->editor_id = $this->factory->user->create( array(
-            'role' => 'editor',
-        ) );
-        $this->author_id = $this->factory->user->create( array(
-            'role' => 'author',
-        ) );
-
         $this->has_setup_template = false;
         add_filter( 'theme_page_templates', array( $this, 'filter_theme_page_templates' ) );
@@ -184 +187 @@
 
         // But they are accessible to authorized users
-        wp_set_current_user( $this->editor_id );
+        wp_set_current_user( self::$editor_id );
         $response = $this->server->dispatch( $request );
         $data = $response->get_data();
@@ -228 +231 @@
 
     public function test_create_item_with_template() {
-        wp_set_current_user( $this->editor_id );
+        wp_set_current_user( self::$editor_id );
 
         $request = new WP_REST_Request( 'POST', '/wp/v2/pages' );
@@ -247 +250 @@
             'type' => 'page',
         ) );
-        wp_set_current_user( $this->editor_id );
+        wp_set_current_user( self::$editor_id );
 
         $request = new WP_REST_Request( 'POST', '/wp/v2/pages' );
@@ -268 +271 @@
 
     public function test_create_page_with_invalid_parent() {
-        wp_set_current_user( $this->editor_id );
+        wp_set_current_user( self::$editor_id );
 
         $request = new WP_REST_Request( 'POST', '/wp/v2/pages' );
@@ -323 +326 @@
         ) );
 
-        wp_set_current_user( $this->editor_id );
+        wp_set_current_user( self::$editor_id );
 
         $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/pages/%d', $page_id ) );
@@ -343 +346 @@
         ) );
 
-        wp_set_current_user( $this->editor_id );
+        wp_set_current_user( self::$editor_id );
 
         $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/pages/%d', $page_id ) );