Changeset 38981 for trunk/src/wp-admin/includes/nav-menu.php

Timestamp:

10/27/2016 03:22:52 PM (8 years ago)

Author:

afercia

Message:

Accessibility: Improve the Menus post type meta boxes pagination links.

• adds hidden text to the pagination links
• slightly increases the links clickable area
• fixes a JS error when clicking on the current page number
• avoids to generate nested <div> elements at each click

Props xavortm, cwpnolen, afercia.

Fixes #35577.

File:

• trunk/src/wp-admin/includes/nav-menu.php (modified) (2 diffs)

trunk/src/wp-admin/includes/nav-menu.php

@@ -359 +359 @@
         ),
         'format' => '',
-        'prev_text' => __('«'),
-        'next_text' => __('»'),
-        'total' => $num_pages,
+        'prev_text'          => '<span aria-label="' . esc_attr__( 'Previous page' ) . '">' . __( '&laquo;' ) . '</span>',
+        'next_text'          => '<span aria-label="' . esc_attr__( 'Next page' ) . '">' . __( '&raquo;' ) . '</span>',
+        'before_page_number' => '<span class="screen-reader-text">' . __( 'Page' ) . '</span> ',
+        'total'   => $num_pages,
         'current' => $pagenum
     ));
@@ -643 +644 @@
         ),
         'format' => '',
-        'prev_text' => __('&laquo;'),
-        'next_text' => __('&raquo;'),
-        'total' => $num_pages,
+        'prev_text'          => '<span aria-label="' . esc_attr__( 'Previous page' ) . '">' . __( '&laquo;' ) . '</span>',
+        'next_text'          => '<span aria-label="' . esc_attr__( 'Next page' ) . '">' . __( '&raquo;' ) . '</span>',
+        'before_page_number' => '<span class="screen-reader-text">' . __( 'Page' ) . '</span> ',
+        'total'   => $num_pages,
         'current' => $pagenum
     ));