Changeset 39018

Timestamp:

10/30/2016 02:58:47 PM (5 years ago)

Author:

westonruter

Message:

Customize: Prevent toggling edit shortcuts when doing shift-click or when clicking on a descendent of an interactive element.

See #38532, #27403.
Fixes #38554.

File:

• trunk/src/wp-includes/js/customize-selective-refresh.js (modified) (1 diff)

trunk/src/wp-includes/js/customize-selective-refresh.js

@@ -1025 +1025 @@
 
             body.on( 'click', function( event ) {
-                if ( $( event.target ).is( '.customize-partial-edit-shortcut, :input, a[href]' ) || 0 !== $( event.target ).closest( 'a' ).length ) {
-                    return; // Don't toggle shortcuts on form, link, or link child clicks.
+                if ( event.shiftKey || $( event.target ).is( '.customize-partial-edit-shortcut, :input, button *, a[href], a[href] *, object, object *, [tabindex], [tabindex] *' ) ) {
+                    return; // Don't toggle shortcuts on shift-clicks or clicks on (or in) interactive elements.
                 }
                 api.selectiveRefresh.editShortcutVisibility.set( 'visible' === api.selectiveRefresh.editShortcutVisibility.get() ? 'hidden' : 'visible' );