Changeset 39038 for trunk/tests/phpunit/tests/ajax/CustomizeMenus.php

Timestamp:

10/30/2016 08:20:54 PM (4 years ago)

Author:

westonruter

Message:

Customize: Prevent auto-draft post/page stubs from being saved with empty slugs or published with non-unique slugs.

• Allow WP_Customize_Nav_Menus::insert_auto_draft_post() to take full post array to pass to wp_insert_post(), except for post_status. Require post_title.
• Ensure empty post_name gets explicitly set to slugified post_title.
• Explicitly allow only post_type and post_title params in WP_Customize_Nav_Menus::ajax_insert_auto_draft_post().
• Use wp_update_post() instead of wp_publish_post() to ensure unique slugs are assigned to published auto-draft posts.
• Re-use WP_Customize_Nav_Menus::insert_auto_draft_post() when inserting stubs from starter content.

See #38114, #38013, #34923.
Fixes #38539.

File:

• trunk/tests/phpunit/tests/ajax/CustomizeMenus.php (modified) (2 diffs)

trunk/tests/phpunit/tests/ajax/CustomizeMenus.php

@@ -548 +548 @@
         $this->assertArrayHasKey( 'post_id', $response['data'] );
         $this->assertArrayHasKey( 'url', $response['data'] );
+        $post = get_post( $response['data']['post_id'] );
+        $this->assertEquals( 'Hello World', $post->post_title );
+        $this->assertEquals( 'post', $post->post_type );
+        $this->assertEquals( 'hello-world', $post->post_name );
     }
 
@@ -636 +640 @@
         $this->assertFalse( $response['success'] );
         $this->assertEquals( 'missing_post_title', $response['data'] );
+
+        // illegal_params.
+        $_POST = wp_slash( array(
+            'customize-menus-nonce' => wp_create_nonce( 'customize-menus' ),
+            'params' => array(
+                'post_type' => 'post',
+                'post_title' => 'OK',
+                'post_name' => 'bad',
+                'post_content' => 'bad',
+            ),
+        ) );
+        $this->_last_response = '';
+        $this->make_ajax_call( 'customize-nav-menus-insert-auto-draft' );
+        $response = json_decode( $this->_last_response, true );
+        $this->assertFalse( $response['success'] );
+        $this->assertEquals( 'illegal_params', $response['data'] );
     }
 }