Changeset 39038 for trunk/tests/phpunit/tests/customize/nav-menus.php

Timestamp:

10/30/2016 08:20:54 PM (8 years ago)

Author:

westonruter

Message:

Customize: Prevent auto-draft post/page stubs from being saved with empty slugs or published with non-unique slugs.

• Allow WP_Customize_Nav_Menus::insert_auto_draft_post() to take full post array to pass to wp_insert_post(), except for post_status. Require post_title.
• Ensure empty post_name gets explicitly set to slugified post_title.
• Explicitly allow only post_type and post_title params in WP_Customize_Nav_Menus::ajax_insert_auto_draft_post().
• Use wp_update_post() instead of wp_publish_post() to ensure unique slugs are assigned to published auto-draft posts.
• Re-use WP_Customize_Nav_Menus::insert_auto_draft_post() when inserting stubs from starter content.

See #38114, #38013, #34923.
Fixes #38539.

File:

• trunk/tests/phpunit/tests/customize/nav-menus.php (modified) (3 diffs)

trunk/tests/phpunit/tests/customize/nav-menus.php

@@ -543 +543 @@
         $this->assertEquals( 'unknown_post_type', $r->get_error_code() );
 
+        $r = $menus->insert_auto_draft_post( array( 'post_status' => 'publish', 'post_title' => 'Bad', 'post_type' => 'post' ) );
+        $this->assertInstanceOf( 'WP_Error', $r );
+        $this->assertEquals( 'status_forbidden', $r->get_error_code() );
+
         $r = $menus->insert_auto_draft_post( array( 'post_title' => 'Hello World', 'post_type' => 'post' ) );
         $this->assertInstanceOf( 'WP_Post', $r );
         $this->assertEquals( 'Hello World', $r->post_title );
+        $this->assertEquals( 'hello-world', $r->post_name );
         $this->assertEquals( 'post', $r->post_type );
-        $this->assertEquals( sanitize_title( $r->post_title ), $r->post_name );
+
+        $r = $menus->insert_auto_draft_post( array( 'post_title' => 'Hello World', 'post_type' => 'post', 'post_name' => 'greetings-world', 'post_content' => 'Hi World' ) );
+        $this->assertInstanceOf( 'WP_Post', $r );
+        $this->assertEquals( 'Hello World', $r->post_title );
+        $this->assertEquals( 'post', $r->post_type );
+        $this->assertEquals( 'greetings-world', $r->post_name );
+        $this->assertEquals( 'Hi World', $r->post_content );
     }
 
@@ -732 +743 @@
             'post_status' => 'auto-draft',
             'post_type' => 'post',
+            'post_name' => 'auto-draft',
         ) );
         $pre_published_post_id = $this->factory()->post->create( array( 'post_status' => 'publish' ) );
@@ -751 +763 @@
             $this->assertEquals( 'publish', get_post_status( $post_id ) );
         }
+
+        // Ensure that unique slugs were assigned.
+        $posts = array_map( 'get_post', $post_ids );
+        $post_names = wp_list_pluck( $posts, 'post_name' );
+        $this->assertEqualSets( $post_names, array_unique( $post_names ) );
     }