Changeset 39048

Timestamp:

10/31/2016 05:44:56 AM (8 years ago)

Author:

pento

Message:

REST API: Allow parameters defined as array to be sent as CSVs.

This allows parameters that are often handled as CSVs to be properly parsed.

Fixes #38586.

Location:

trunk

Files:

• src/wp-includes/rest-api.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-schema-validation.php (modified) (1 diff)

trunk/src/wp-includes/rest-api.php

@@ -997 +997 @@
     if ( 'array' === $args['type'] ) {
         if ( ! is_array( $value ) ) {
-            return new WP_Error( 'rest_invalid_param', sprintf( /* translators: 1: parameter, 2: type name */ __( '%1$s is not of type %2$s.' ), $param, 'array' ) );
+            $value = preg_split( '/[\s,]+/', $value );
         }
         foreach ( $value as $index => $v ) {

trunk/tests/phpunit/tests/rest-api/rest-schema-validation.php

@@ -104 +104 @@
         $this->assertWPError( rest_validate_value_from_schema( array( true ), $schema ) );
     }
+
+    public function test_type_array_as_csv() {
+        $schema = array(
+            'type' => 'array',
+            'items' => array(
+                'type' => 'number',
+            ),
+        );
+        $this->assertTrue( rest_validate_value_from_schema( '1', $schema ) );
+        $this->assertTrue( rest_validate_value_from_schema( '1,2,3', $schema ) );
+        $this->assertWPError( rest_validate_value_from_schema( 'lol', $schema ) );
+    }
 }