Changeset 39055

Timestamp:

10/31/2016 11:05:37 AM (8 years ago)

Author:

pento

Message:

REST API: Allow a CSV list of term IDs to be passed to /posts.

[39048] added CSV support to array types, this change explicitly parses term lists as IDs, and adds tests.

Props timmydcrawford, pento.
Fixes #38553.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (3 diffs)
• tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1197 +1197 @@
             }
 
-            $terms  = array_map( 'absint', $request[ $base ] );
-            $result = wp_set_object_terms( $post_id, $terms, $taxonomy->name );
+            $result = wp_set_object_terms( $post_id, $request[ $base ], $taxonomy->name );
 
             if ( is_wp_error( $result ) ) {
@@ -1966 +1965 @@
                     'type'    => 'integer',
                 ),
+                'arg_options' => array(
+                    'sanitize_callback' => 'wp_parse_id_list',
+                ),
                 'context'     => array( 'view', 'edit' ),
             );
@@ -1971 +1973 @@
                 'description' => sprintf( __( 'The terms in the %s taxonomy that should not be assigned to the object.' ), $taxonomy->name ),
                 'type'        => 'array',
+                'items'       => array(
+                    'type'    => 'integer',
+                ),
+                'arg_options' => array(
+                    'sanitize_callback' => 'wp_parse_id_list',
+                ),
                 'context'     => array( 'view', 'edit' ),
             );

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -200 +200 @@
         $this->assertTrue( in_array( $id1, wp_list_pluck( $data, 'id' ), true ) );
         $this->assertTrue( in_array( $id2, wp_list_pluck( $data, 'id' ), true ) );
+
         $request->set_param( 'exclude', array( $id2 ) );
+        $response = $this->server->dispatch( $request );
+        $data = $response->get_data();
+        $this->assertTrue( in_array( $id1, wp_list_pluck( $data, 'id' ), true ) );
+        $this->assertFalse( in_array( $id2, wp_list_pluck( $data, 'id' ), true ) );
+
+        $request->set_param( 'exclude', "$id2" );
         $response = $this->server->dispatch( $request );
         $data = $response->get_data();
@@ -1303 +1310 @@
         $data = $response->get_data();
         $this->assertEquals( array( $category['term_id'] ), $data['categories'] );
+    }
+
+    public function test_create_post_with_categories_as_csv() {
+        wp_set_current_user( self::$editor_id );
+        $category = wp_insert_term( 'Chicken', 'category' );
+        $category2 = wp_insert_term( 'Ribs', 'category' );
+        $request = new WP_REST_Request( 'POST', '/wp/v2/posts' );
+        $params = $this->set_post_data( array(
+            'categories' => $category['term_id'] . ',' . $category2['term_id'],
+        ) );
+        $request->set_body_params( $params );
+        $response = $this->server->dispatch( $request );
+
+        $data = $response->get_data();
+        $this->assertEquals( array( $category['term_id'], $category2['term_id'] ), $data['categories'] );
     }