Changeset 39056

Timestamp:

10/31/2016 11:10:37 AM (3 years ago)

Author:

pento

Message:

REST API: Allow a CSV list of user roles to be passed to /users.

After [39048], this changes explicitly parses the list of user roles as slugs, and adds tests.

Props jnylen0.
Fixes #38557.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-users-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php

@@ -1011 +1011 @@
                     ),
                     'context'     => array( 'edit' ),
+                    'arg_options' => array(
+                        'sanitize_callback' => 'wp_parse_slug_list',
+                    ),
                 ),
                 'password'        => array(

trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -905 +905 @@
 
         $user = get_userdata( $user_id );
+        $this->assertArrayHasKey( 'editor', $user->caps );
+        $this->assertArrayNotHasKey( 'administrator', $user->caps );
+    }
+
+    public function test_update_user_multiple_roles() {
+        $user_id = $this->factory->user->create( array( 'role' => 'administrator' ) );
+
+        wp_set_current_user( self::$user );
+        $this->allow_user_to_manage_multisite();
+
+        $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/users/%d', $user_id ) );
+        $request->set_param( 'roles', 'author,editor' );
+        $response = $this->server->dispatch( $request );
+
+        $new_data = $response->get_data();
+
+        $this->assertEquals( array( 'author', 'editor' ), $new_data['roles'] );
+
+        $user = get_userdata( $user_id );
+        $this->assertArrayHasKey( 'author', $user->caps );
         $this->assertArrayHasKey( 'editor', $user->caps );
         $this->assertArrayNotHasKey( 'administrator', $user->caps );