Changeset 39062 for trunk/tests/phpunit/tests/admin/includesPost.php

Timestamp:

10/31/2016 07:29:07 PM (8 years ago)

Author:

johnbillion

Message:

Posts, Post Types: Prevent users from being able to delete a protected meta field from a post.

Previously a user could remove a protected meta field by using their browser developer tools to alter the form field properties in the Custom Fields meta box, given that they know the ID of the protected meta field. This change prevents this by preventing any change to a protected meta field, including changing its key.

Props ajoah, johnbillion, peterwilsoncc
Fixes #38293

File:

• trunk/tests/phpunit/tests/admin/includesPost.php (modified) (2 diffs)

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -246 +246 @@
 
     /**
+     * @ticket 38293
+     */
+    public function test_user_cant_delete_protected_meta() {
+        $protected_meta_key = '_test_meta_data_that_is_protected';
+
+        // Add some protected meta data.
+        $post_id = self::$post_id;
+        $meta_id = add_post_meta( $post_id, $protected_meta_key, 'protected' );
+
+        // User editing the post should not effect outcome.
+        $expected = get_post_meta( $post_id, $protected_meta_key );
+
+        // Attempt to edit the post.
+        wp_set_current_user( self::$admin_id );
+
+        $post_data = array(
+            'post_ID' => $post_id,
+            'meta'    => array(
+                $meta_id => array(
+                    'key'   => 'unprotected_meta_key',
+                    'value' => 'protected',
+                ),
+            ),
+        );
+        edit_post( $post_data );
+
+        $actual = get_post_meta( $post_id, $protected_meta_key );
+        $this->assertSame( $expected, $actual );
+
+        // Tidy up.
+        delete_metadata_by_mid( 'post', $meta_id );
+    }
+
+    /**
      * @ticket 30910
      */
@@ -599 +633 @@
         $this->assertSame( $p, post_exists( $title, $content, $date ) );
     }
+
 }