Changeset 39084 for trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

Timestamp:

11/02/2016 03:36:40 AM (10 years ago)

Author:

rmccue

Message:

REST API: Only expose formats supported by the current theme.

While it's valid to save any format to the database, and WordPress is totally fine with that, we should only include the formats specified by the theme in the schema.

Props danielbachhuber.
Fixes #38610.

File:

• trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (4 diffs)

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -17 +17 @@
         protected static $contributor_id;
 
+        protected static $supported_formats;
+
         public static function wpSetUpBeforeClass( $factory ) {
                 self::$post_id = $factory->post->create();
@@ -29 +31 @@
                         'role' => 'contributor',
                 ) );
+
+                // Only support 'post' and 'gallery'
+                self::$supported_formats = get_theme_support( 'post-formats' );
+                add_theme_support( 'post-formats', array( 'post', 'gallery' ) );
         }
 
         public static function wpTearDownAfterClass() {
+                // Restore theme support for formats.
+                if ( self::$supported_formats ) {
+                        add_theme_support( 'post-formats', self::$supported_formats );
+                } else {
+                        remove_theme_support( 'post-formats' );
+                }
+
                 wp_delete_post( self::$post_id, true );
 
@@ -1079 +1092 @@
         }
 
+        /**
+         * Test with a valid format, but one unsupported by the theme.
+         *
+         * https://core.trac.wordpress.org/ticket/38610
+         */
+        public function test_create_post_with_unsupported_format() {
+                wp_set_current_user( self::$editor_id );
+
+                $request = new WP_REST_Request( 'POST', '/wp/v2/posts' );
+                $params = $this->set_post_data( array(
+                        'format' => 'link',
+                ) );
+                $request->set_body_params( $params );
+                $response = $this->server->dispatch( $request );
+
+                $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+        }
+
         public function test_create_update_post_with_featured_media() {
 
@@ -1491 +1522 @@
                 $params = $this->set_post_data( array(
                         'format' => 'testformat',
+                ) );
+                $request->set_body_params( $params );
+                $response = $this->server->dispatch( $request );
+
+                $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+        }
+
+        /**
+         * Test with a valid format, but one unsupported by the theme.
+         *
+         * https://core.trac.wordpress.org/ticket/38610
+         */
+        public function test_update_post_with_unsupported_format() {
+                wp_set_current_user( self::$editor_id );
+
+                $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+                $params = $this->set_post_data( array(
+                        'format' => 'link',
                 ) );
                 $request->set_body_params( $params );