Changeset 39101 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

Timestamp:

11/03/2016 01:11:30 AM (8 years ago)

Author:

rachelbaker

Message:

REST API: Return an error when the length of a comment field is too long.

Introduces wp_check_comment_data_max_lengths() which allows both the REST API comments endpoints and wp_handle_comment_submission() to check the length of the comment content, author name, author url, and author email fields against their respective database columns.

Props rachelbaker, mangeshp, salcode, pento.
Fixes #38477.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -485 +485 @@
         }
 
+        $check_comment_lengths = wp_check_comment_data_max_lengths( $prepared_comment );
+        if ( is_wp_error( $check_comment_lengths ) ) {
+            $error_code = $check_comment_lengths->get_error_code();
+            return new WP_Error( $error_code, __( 'Comment field exceeds maximum length allowed.' ), array( 'status' => 400 ) );
+        }
+
         $prepared_comment['comment_approved'] = wp_allow_comment( $prepared_comment, true );
 
@@ -631 +637 @@
 
             $prepared_args['comment_ID'] = $id;
+
+            $check_comment_lengths = wp_check_comment_data_max_lengths( $prepared_args );
+            if ( is_wp_error( $check_comment_lengths ) ) {
+                $error_code = $check_comment_lengths->get_error_code();
+                return new WP_Error( $error_code, __( 'Comment field exceeds maximum length allowed.' ), array( 'status' => 400 ) );
+            }
 
             $updated = wp_update_comment( $prepared_args );