Changeset 39105 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

Timestamp:

11/03/2016 02:17:39 AM (8 years ago)

Author:

rachelbaker

Message:

REST API: Clean-up our validation callbacks and add missing array items properties in our endpoint schemas.

Props joehoyle, jnylen0.
Fixes #38617.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (15 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -1115 +1115 @@
                     'format'       => 'ipv4',
                     'context'      => array( 'edit' ),
-                    'arg_options'  => array(
-                        'default'           => '127.0.0.1',
-                    ),
+                    'default'      => '127.0.0.1',
                 ),
                 'author_name'     => array(
@@ -1189 +1187 @@
                     'type'         => 'integer',
                     'context'      => array( 'view', 'edit', 'embed' ),
-                    'arg_options'  => array(
-                        'default'           => 0,
-                    ),
+                    'default'      => 0,
                 ),
                 'post'             => array(
@@ -1197 +1193 @@
                     'type'         => 'integer',
                     'context'      => array( 'view', 'edit' ),
-                    'arg_options'  => array(
-                        'default'           => 0,
-                    ),
+                    'default'      => 0,
                 ),
                 'status'           => array(
@@ -1265 +1259 @@
             'type'              => 'string',
             'format'            => 'date-time',
-            'validate_callback' => 'rest_validate_request_arg',
         );
 
         $query_params['author'] = array(
             'description'       => __( 'Limit result set to comments assigned to specific user ids. Requires authorization.' ),
-            'sanitize_callback' => 'wp_parse_id_list',
             'type'              => 'array',
+            'items'             => array(
+                'type'          => 'integer',
+            ),
         );
 
         $query_params['author_exclude'] = array(
             'description'       => __( 'Ensure result set excludes comments assigned to specific user ids. Requires authorization.' ),
-            'sanitize_callback' => 'wp_parse_id_list',
             'type'              => 'array',
+            'items'             => array(
+                'type'          => 'integer',
+            ),
         );
 
@@ -1284 +1281 @@
             'description'       => __( 'Limit result set to that from a specific author email. Requires authorization.' ),
             'format'            => 'email',
-            'sanitize_callback' => 'sanitize_email',
             'type'              => 'string',
         );
@@ -1292 +1288 @@
             'type'              => 'string',
             'format'            => 'date-time',
-            'validate_callback' => 'rest_validate_request_arg',
         );
 
@@ -1298 +1293 @@
             'description'        => __( 'Ensure result set excludes specific ids.' ),
             'type'               => 'array',
+            'items'              => array(
+                'type'           => 'integer',
+            ),
             'default'            => array(),
-            'sanitize_callback'  => 'wp_parse_id_list',
         );
 
@@ -1305 +1302 @@
             'description'        => __( 'Limit result set to specific ids.' ),
             'type'               => 'array',
+            'items'              => array(
+                'type'           => 'integer',
+            ),
             'default'            => array(),
-            'sanitize_callback'  => 'wp_parse_id_list',
         );
 
@@ -1312 +1311 @@
             'default'           => null,
             'description'       => __( 'Limit result set to that of a particular comment karma. Requires authorization.' ),
-            'sanitize_callback' => 'absint',
             'type'              => 'integer',
-            'validate_callback'  => 'rest_validate_request_arg',
         );
 
@@ -1320 +1317 @@
             'description'        => __( 'Offset the result set by a specific number of comments.' ),
             'type'               => 'integer',
-            'sanitize_callback'  => 'absint',
-            'validate_callback'  => 'rest_validate_request_arg',
         );
 
@@ -1327 +1322 @@
             'description'           => __( 'Order sort attribute ascending or descending.' ),
             'type'                  => 'string',
-            'sanitize_callback'     => 'sanitize_key',
-            'validate_callback'     => 'rest_validate_request_arg',
             'default'               => 'desc',
             'enum'                  => array(
@@ -1339 +1332 @@
             'description'           => __( 'Sort collection by object attribute.' ),
             'type'                  => 'string',
-            'sanitize_callback'     => 'sanitize_key',
-            'validate_callback'     => 'rest_validate_request_arg',
             'default'               => 'date_gmt',
             'enum'                  => array(
@@ -1356 +1347 @@
             'default'           => array(),
             'description'       => __( 'Limit result set to resources of specific parent ids.' ),
-            'sanitize_callback' => 'wp_parse_id_list',
             'type'              => 'array',
+            'items'             => array(
+                'type'          => 'integer',
+            ),
         );
 
@@ -1363 +1356 @@
             'default'           => array(),
             'description'       => __( 'Ensure result set excludes specific parent ids.' ),
-            'sanitize_callback' => 'wp_parse_id_list',
             'type'              => 'array',
+            'items'             => array(
+                'type'          => 'integer',
+            ),
         );
 
@@ -1371 +1366 @@
             'description'       => __( 'Limit result set to resources assigned to specific post ids.' ),
             'type'              => 'array',
-            'sanitize_callback' => 'wp_parse_id_list',
+            'items'             => array(
+                'type'          => 'integer',
+            ),
         );