Changeset 39105 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

Timestamp:

11/03/2016 02:17:39 AM (8 years ago)

Author:

rachelbaker

Message:

REST API: Clean-up our validation callbacks and add missing array items properties in our endpoint schemas.

Props joehoyle, jnylen0.
Fixes #38617.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (14 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1976 +1976 @@
                     'type'    => 'integer',
                 ),
-                'arg_options' => array(
-                    'sanitize_callback' => 'wp_parse_id_list',
-                ),
-                'context'     => array( 'view', 'edit' ),
-            );
-            $schema['properties'][ $base . '_exclude' ] = array(
-                'description' => sprintf( __( 'The terms in the %s taxonomy that should not be assigned to the object.' ), $taxonomy->name ),
-                'type'        => 'array',
-                'items'       => array(
-                    'type'    => 'integer',
-                ),
-                'arg_options' => array(
-                    'sanitize_callback' => 'wp_parse_id_list',
-                ),
                 'context'     => array( 'view', 'edit' ),
             );
@@ -2014 +2000 @@
             'type'               => 'string',
             'format'             => 'date-time',
-            'validate_callback'  => 'rest_validate_request_arg',
         );
 
@@ -2021 +2006 @@
                 'description'         => __( 'Limit result set to posts assigned to specific authors.' ),
                 'type'                => 'array',
+                'items'               => array(
+                    'type'            => 'integer',
+                ),
                 'default'             => array(),
-                'sanitize_callback'   => 'wp_parse_id_list',
             );
             $params['author_exclude'] = array(
                 'description'         => __( 'Ensure result set excludes posts assigned to specific authors.' ),
                 'type'                => 'array',
+                'items'               => array(
+                    'type'            => 'integer',
+                ),
                 'default'             => array(),
-                'sanitize_callback'   => 'wp_parse_id_list',
             );
         }
@@ -2036 +2025 @@
             'type'               => 'string',
             'format'             => 'date-time',
-            'validate_callback'  => 'rest_validate_request_arg',
         );
 
@@ -2042 +2030 @@
             'description'        => __( 'Ensure result set excludes specific ids.' ),
             'type'               => 'array',
+            'items'              => array(
+                'type'           => 'integer',
+            ),
             'default'            => array(),
-            'sanitize_callback'  => 'wp_parse_id_list',
         );
 
@@ -2049 +2039 @@
             'description'        => __( 'Limit result set to specific ids.' ),
             'type'               => 'array',
+            'items'              => array(
+                'type'           => 'integer',
+            ),
             'default'            => array(),
-            'sanitize_callback'  => 'wp_parse_id_list',
         );
 
@@ -2057 +2049 @@
                 'description'        => __( 'Limit result set to resources with a specific menu_order value.' ),
                 'type'               => 'integer',
-                'sanitize_callback'  => 'absint',
-                'validate_callback'  => 'rest_validate_request_arg',
             );
         }
@@ -2065 +2055 @@
             'description'        => __( 'Offset the result set by a specific number of items.' ),
             'type'               => 'integer',
-            'sanitize_callback'  => 'absint',
-            'validate_callback'  => 'rest_validate_request_arg',
         );
 
@@ -2074 +2062 @@
             'default'            => 'desc',
             'enum'               => array( 'asc', 'desc' ),
-            'validate_callback'  => 'rest_validate_request_arg',
         );
 
@@ -2089 +2076 @@
                 'slug',
             ),
-            'validate_callback'  => 'rest_validate_request_arg',
         );
 
@@ -2102 +2088 @@
                 'description'       => __( 'Limit result set to those of particular parent ids.' ),
                 'type'              => 'array',
-                'sanitize_callback' => 'wp_parse_id_list',
+                'items'             => array(
+                    'type'          => 'integer',
+                ),
                 'default'           => array(),
             );
@@ -2108 +2096 @@
                 'description'       => __( 'Limit result set to all items except those of a particular parent id.' ),
                 'type'              => 'array',
-                'sanitize_callback' => 'wp_parse_id_list',
+                'items'             => array(
+                    'type'          => 'integer',
+                ),
                 'default'           => array(),
             );
@@ -2138 +2128 @@
                 'description'       => sprintf( __( 'Limit result set to all items that have the specified term assigned in the %s taxonomy.' ), $base ),
                 'type'              => 'array',
-                'sanitize_callback' => 'wp_parse_id_list',
+                'items'             => array(
+                    'type'          => 'integer',
+                ),
+                'default'           => array(),
+            );
+
+            $params[ $base . '_exclude' ] = array(
+                'description' => sprintf( __( 'Limit result set to all items except those that have the specified term assigned in the %s taxonomy.' ), $base ),
+                'type'        => 'array',
+                'items'       => array(
+                    'type'    => 'integer',
+                ),
                 'default'           => array(),
             );
@@ -2147 +2148 @@
                 'description'       => __( 'Limit result set to items that are sticky.' ),
                 'type'              => 'boolean',
-                'sanitize_callback' => 'rest_parse_request_arg',
             );
         }