Changeset 39105 for trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

Timestamp:

11/03/2016 02:17:39 AM (8 years ago)

Author:

rachelbaker

Message:

REST API: Clean-up our validation callbacks and add missing array items properties in our endpoint schemas.

Props joehoyle, jnylen0.
Fixes #38617.

File:

• trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (12 diffs)

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -93 +93 @@
             'before',
             'categories',
+            'categories_exclude',
             'context',
             'exclude',
@@ -106 +107 @@
             'sticky',
             'tags',
+            'tags_exclude',
             ), $keys );
     }
@@ -184 +186 @@
         $this->assertNotEquals( self::$editor_id, $data[0]['author'] );
         $this->assertNotEquals( self::$editor_id, $data[1]['author'] );
+        // invalid author_exclude errors
+        $request = new WP_REST_Request( 'GET', '/wp/v2/posts' );
+        $request->set_param( 'author_exclude', 'invalid' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -203 +210 @@
         $this->assertEquals( 2, count( $data ) );
         $this->assertEquals( $id1, $data[0]['id'] );
+        // Invalid include should error
+        $request = new WP_REST_Request( 'GET', '/wp/v2/posts' );
+        $request->set_param( 'include', 'invalid' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -225 +237 @@
         $this->assertTrue( in_array( $id1, wp_list_pluck( $data, 'id' ), true ) );
         $this->assertFalse( in_array( $id2, wp_list_pluck( $data, 'id' ), true ) );
+
+        $request->set_param( 'exclude', 'invalid' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -407 +423 @@
         $data = $response->get_data();
         $this->assertEquals( 'Apple Cobbler', $data[0]['title']['rendered'] );
+        // order=>asc,id should fail
+        $request->set_param( 'order', 'asc,id' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+        // orderby=>content should fail (invalid param test)
+        $request->set_param( 'order', 'asc' );
+        $request->set_param( 'orderby', 'content' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -457 +482 @@
         $response = $this->server->dispatch( $request );
         $this->assertCount( 2, $response->get_data() );
+        // Invalid 'offset' should error
+        $request->set_param( 'offset', 'moreplease' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -513 +542 @@
         $response = $this->server->dispatch( $request );
         $this->assertCount( 1, $response->get_data() );
+
+        $request->set_param( 'tags', array( 'my-tag' ) );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -535 +568 @@
         $this->assertCount( 1, $data );
         $this->assertEquals( $id2, $data[0]['id'] );
+
+        $request->set_param( 'tags_exclude', array( 'my-tag' ) );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -552 +589 @@
         $post = $posts[0];
         $this->assertEquals( $id2, $post['id'] );
+
+        $request->set_param( 'sticky', 'nothanks' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -1990 +2031 @@
         $data = $response->get_data();
         $properties = $data['schema']['properties'];
-        $this->assertEquals( 25, count( $properties ) );
+        $this->assertEquals( 23, count( $properties ) );
         $this->assertArrayHasKey( 'author', $properties );
         $this->assertArrayHasKey( 'comment_status', $properties );
@@ -2013 +2054 @@
         $this->assertArrayHasKey( 'type', $properties );
         $this->assertArrayHasKey( 'tags', $properties );
-        $this->assertArrayHasKey( 'tags_exclude', $properties );
         $this->assertArrayHasKey( 'categories', $properties );
-        $this->assertArrayHasKey( 'categories_exclude', $properties );
     }