Changeset 39105 for trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

Timestamp:

11/03/2016 02:17:39 AM (8 years ago)

Author:

rachelbaker

Message:

REST API: Clean-up our validation callbacks and add missing array items properties in our endpoint schemas.

Props joehoyle, jnylen0.
Fixes #38617.

File:

• trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php (modified) (6 diffs)

trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

@@ -99 +99 @@
         $this->assertEquals( 'Season 5', $data[0]['name'] );
         $this->assertEquals( 'The Be Sharps', $data[1]['name'] );
+        // invalid value should fail
+        $request->set_param( 'hide_empty', 'nothanks' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -118 +122 @@
         $this->assertEquals( 2, count( $data ) );
         $this->assertEquals( $id3, $data[0]['id'] );
+        // Include invalid value shoud fail
+        $request->set_param( 'include', array( 'myterm' ) );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -133 +141 @@
         $this->assertTrue( in_array( $id1, wp_list_pluck( $data, 'id' ), true ) );
         $this->assertFalse( in_array( $id2, wp_list_pluck( $data, 'id' ), true ) );
+        // Invalid exclude value should fail
+        $request->set_param( 'exclude', array( 'invalid' ) );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -152 +164 @@
         $response = $this->server->dispatch( $request );
         $this->assertCount( 2, $response->get_data() );
+        // 'offset' invalid value shoudl fail
+        $request->set_param( 'offset', 'moreplease' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -182 +198 @@
         $this->assertEquals( 2, count( $data ) );
         $this->assertEquals( 'Apple', $data[0]['name'] );
+        // Invalid orderby should fail.
+        $request->set_param( 'orderby', 'invalid' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }
 
@@ -232 +252 @@
         $this->assertEquals( 2, count( $data ) );
         $this->assertEquals( 'DC', $data[0]['name'] );
+
+        // Invalid post should error.
+        $request = new WP_REST_Request( 'GET', '/wp/v2/tags' );
+        $request->set_param( 'post', 'invalid-post' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }