Changeset 39109 for trunk/tests/phpunit/tests/rest-api/rest-request.php

Timestamp:

11/03/2016 04:04:41 AM (8 years ago)

Author:

joehoyle

Message:

REST API: Return error when JSON decoding fails.

If you send a request to the REST API with invalid JSON in body than it will now return a error. This assists developers if they accidentally send invalid JSON and wonder why their data appears to be ignored.

Props rmccue.
Fixes #38547.

File:

• trunk/tests/phpunit/tests/rest-api/rest-request.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-request.php

@@ -398 +398 @@
         $this->assertWPError( $valid );
         $this->assertEquals( 'rest_invalid_param', $valid->get_error_code() );
+    }
+
+    public function test_has_valid_params_json_error() {
+        if ( version_compare( PHP_VERSION, '5.3', '<' ) ) {
+            return $this->markTestSkipped( 'JSON validation is only available for PHP 5.3+' );
+        }
+
+        $this->request->set_header( 'Content-Type', 'application/json' );
+        $this->request->set_body( '{"invalid": JSON}' );
+
+        $valid = $this->request->has_valid_params();
+        $this->assertWPError( $valid );
+        $this->assertEquals( 'rest_invalid_json', $valid->get_error_code() );
+        $data = $valid->get_error_data();
+        $this->assertEquals( JSON_ERROR_SYNTAX, $data['json_error_code'] );
     }