Changeset 39126 for trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

Timestamp:

11/03/2016 08:04:59 PM (8 years ago)

Author:

rachelbaker

Message:

REST API: Modify the structure of our DELETE responses to be more explicit.

Add the deleted property to the root of the Response object to communicate if the delete action was successful. Move the state of the resource prior to the delete request under a new previous property. As a result DELETE responses are now structured like so:

{ deleted: true, previous: { ... } }

Also includes helpful information to DELETE requests for resources that are not trashable.

Props timmydcrawford, rmccue, jnylen0.
Fixes #38494.

File:

• trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

@@ -626 +626 @@
         $this->assertEquals( 200, $response->get_status() );
         $data = $response->get_data();
-        $this->assertEquals( 'Deleted Tag', $data['name'] );
-    }
-
-    public function test_delete_item_force_false() {
+        $this->assertTrue( $data['deleted'] );
+        $this->assertEquals( 'Deleted Tag', $data['previous']['name'] );
+    }
+
+    public function test_delete_item_no_trash() {
         wp_set_current_user( self::$administrator );
         $term = get_term_by( 'id', $this->factory->tag->create( array( 'name' => 'Deleted Tag' ) ), 'post_tag' );
+
         $request = new WP_REST_Request( 'DELETE', '/wp/v2/tags/' . $term->term_id );
-        // force defaults to false
-        $response = $this->server->dispatch( $request );
-        $this->assertEquals( 501, $response->get_status() );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_trash_not_supported', $response, 501 );
+
+        $request->set_param( 'force', 'false' );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_trash_not_supported', $response, 501 );
     }
 
@@ -668 +673 @@
         $this->assertEquals( 200, $response->get_status() );
         $data = $response->get_data();
-        $this->assertEquals( 'Deleted Tag', $data['name'] );
+        $this->assertTrue( $data['deleted'] );
+        $this->assertEquals( 'Deleted Tag', $data['previous']['name'] );
     }