WordPress.org

Make WordPress Core

Changeset 39129


Ignore:
Timestamp:
11/03/2016 10:01:46 PM (5 years ago)
Author:
davidakennedy
Message:

Twenty Seventeen: Correct issues with hidden overflow and height on site header

In -r39124, some additional issues were introduced:

  • The 'overflow: hidden' on the .site-header; was added to prevent a side-scrolling issue, but it ended up cutting off the menu. It looks like the cause of the side-scroll was related to how the scroll down icon was rotated, so it's addressed by rotating the icon and not the <a>.
  • Also, min-height doesn't play well with display: table; in Firefox. So it's addressed with just height.

Props laurelfulford, sami.keijonen.

See #38543.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-content/themes/twentyseventeen/style.css

    r39124 r39129  
    15431543    background-color: #fafafa;
    15441544    position: relative;
    1545     overflow: hidden;
    15461545}
    15471546
     
    16371636.has-header-image.home.blog .custom-header {
    16381637    display: table;
    1639     height: 100%;
    1640     min-height: 300px;
    1641     min-height: 75vh;
     1638    height: 300px;
     1639    height: 75vh;
    16421640    width: 100%;
    16431641}
     
    32583256    .has-header-image.home.blog .custom-header {
    32593257        display: block;
    3260         min-height: 0;
     3258        height: auto;
    32613259    }
    32623260
     
    35223520        position: absolute;
    35233521        right: 0;
     3522    }
     3523
     3524    .site-header .menu-scroll-down .icon {
    35243525        -webkit-transform: rotate(90deg); /* Chrome, Safari, Opera */
    35253526        -ms-transform: rotate(90deg); /* IE 9 */
Note: See TracChangeset for help on using the changeset viewer.