Changeset 39135

Timestamp:

11/03/2016 11:07:20 PM (8 years ago)

Author:

davidakennedy

Message:

Twenty Seventeen: Make sure skip link works in all versions of Internet Explorer

This also reduces the number of browsers detected and patched with this fix. Most modern browsers have patched this common bug, where an anchor link does not move focus when clicked. Twenty Seventeen will only worry about older versions of Internet Explorer in this regard.

Props afercia, sami.keijonen.

See #38604.

Location:

trunk/src/wp-content/themes/twentyseventeen

Files:

• assets/js/skip-link-focus-fix.js (modified) (1 diff)
• style.css (modified) (1 diff)

trunk/src/wp-content/themes/twentyseventeen/assets/js/skip-link-focus-fix.js

@@ -7 +7 @@
  */
 ( function() {
-    var isWebkit = navigator.userAgent.toLowerCase().indexOf( 'webkit' ) > -1,
-        isOpera  = navigator.userAgent.toLowerCase().indexOf( 'opera' )  > -1,
-        isIe     = navigator.userAgent.toLowerCase().indexOf( 'msie' )   > -1;
+    var isIe = /(trident|msie)/i.test( navigator.userAgent );
 
-    if ( ( isWebkit || isOpera || isIe ) && document.getElementById && window.addEventListener ) {
+    if ( isIe && document.getElementById && window.addEventListener ) {
         window.addEventListener( 'hashchange', function() {
             var id = location.hash.substring( 1 ),

trunk/src/wp-content/themes/twentyseventeen/style.css

@@ -329 +329 @@
     width: auto;
     z-index: 100000; /* Above WP toolbar. */
-}
-
-/* Do not show the outline on the skip link target. */
-
-#content[tabindex="-1"]:focus {
-    outline: 0;
 }