Changeset 39137 for trunk/tests/phpunit/tests/ajax/CustomizeMenus.php

Timestamp:

11/04/2016 06:03:51 AM (10 years ago)

Author:

westonruter

Message:

Customize: Combine Ajax requests for initial load of available nav menu items into a single request.

When there are many post types registered, prevent Ajax requests from piling up and slamming WordPress with concurrent requests.

Props curdin, westonruter.
Fixes #36697.

File:

• trunk/tests/phpunit/tests/ajax/CustomizeMenus.php (modified) (5 diffs)

trunk/tests/phpunit/tests/ajax/CustomizeMenus.php

@@ -175 +175 @@
                         array(
                                 array(
+                                        'type'     => 'post_type',
+                                        'object'   => '',
+                                ),
+                                array(
+                                        'success'  => false,
+                                        'data'     => 'nav_menus_missing_type_or_object_parameter',
+                                ),
+                        ),
+                        // Testing empty type.
+                        array(
+                                array(
                                         'type'     => '',
                                         'object'   => 'post',
@@ -183 +194 @@
                                 ),
                         ),
-                        // Testing empty type.
-                        array(
-                                array(
-                                        'type'     => '',
-                                        'object'   => 'post',
+                        // Testing empty type of a bulk request.
+                        array(
+                                array(
+                                        'item_types' => array(
+                                                array(
+                                                        'type'     => 'post_type',
+                                                        'object'   => 'post',
+                                                ),
+                                                array(
+                                                        'type'     => 'post_type',
+                                                        'object'   => '',
+                                                ),
+                                        ),
                                 ),
                                 array(
@@ -274 +293 @@
                                         'type'     => 'taxonomy',
                                         'object'   => 'post_tag',
+                                ),
+                                true,
+                        ),
+                        // Testing a bulk request.
+                        array(
+                                array(
+                                        'item_types' => array(
+                                                array(
+                                                        'type'     => 'post_type',
+                                                        'object'   => 'post',
+                                                ),
+                                                array(
+                                                        'type'     => 'post_type',
+                                                        'object'   => 'page',
+                                                ),
+                                        ),
                                 ),
                                 true,
@@ -314 +349 @@
                 $response = json_decode( $this->_last_response, true );
 
-                $this->assertNotEmpty( $response['data']['items'] );
+                $this->assertNotEmpty( current( $response['data']['items'] ) );
 
                 // Get the second index to avoid the home page edge case.
-                $test_item = $response['data']['items'][1];
+                $first_prop = current( $response['data']['items'] );
+                $test_item = $first_prop[1];
 
                 foreach ( $expected_keys as $key ) {
@@ -326 +362 @@
                 // Special test for the home page.
                 if ( 'page' === $test_item['object'] ) {
-                        $home = $response['data']['items'][0];
+                        $first_prop = current( $response['data']['items'] );
+                        $home = $first_prop[0];
                         foreach ( $expected_keys as $key ) {
                                 if ( 'object_id' !== $key ) {