Changeset 39140 for trunk/src/wp-admin/includes/theme.php

Timestamp:

11/04/2016 03:53:01 PM (8 years ago)

Author:

helen

Message:

Customize: Revert theme install feature.

This is a great goal for core, and is close, but it is not in shape to be shipped for 4.7 and there is not enough time left in the development cycle to alter and polish sufficiently. There are bugs, but more than that, there are more fundamental questions around the use of existing UI, general UX, and how findable themes are (not) on the .org side.

see #37661.

File:

• trunk/src/wp-admin/includes/theme.php (modified) (4 diffs)

trunk/src/wp-admin/includes/theme.php

@@ -610 +610 @@
  */
 function customize_themes_print_templates() {
+    $preview_url = esc_url( add_query_arg( 'theme', '__THEME__' ) ); // Token because esc_url() strips curly braces.
+    $preview_url = str_replace( '__THEME__', '{{ data.id }}', $preview_url );
     ?>
     <script type="text/html" id="tmpl-customize-themes-details-view">
@@ -621 +623 @@
             <div class="theme-about wp-clearfix">
                 <div class="theme-screenshots">
-                <# if ( data.screenshot && data.screenshot[0] ) { #>
+                <# if ( data.screenshot[0] ) { #>
                     <div class="screenshot"><img src="{{ data.screenshot[0] }}" alt="" /></div>
                 <# } else { #>
@@ -634 +636 @@
                     <h2 class="theme-name">{{{ data.name }}}<span class="theme-version"><?php printf( __( 'Version: %s' ), '{{ data.version }}' ); ?></span></h2>
                     <h3 class="theme-author"><?php printf( __( 'By %s' ), '{{{ data.authorAndUri }}}' ); ?></h3>
-
-                    <# if ( data.stars && 0 != data.num_ratings ) { #>
-                        <div class="theme-rating">
-                            {{{ data.stars }}}
-                            <span class="num-ratings"><?php echo sprintf( __( '(%s ratings)' ), '{{ data.num_ratings }}' ); ?></span>
-                        </div>
-                    <# } #>
-
-                    <# if ( data.hasUpdate ) { #>
-                        <div class="notice notice-warning notice-alt notice-large" data-slug="{{ data.id }}">
-                            <h3 class="notice-title"><?php _e( 'Update Available' ); ?></h3>
-                            {{{ data.update }}}
-                        </div>
-                    <# } #>
-
                     <p class="theme-description">{{{ data.description }}}</p>
 
@@ -654 +641 @@
                         <p class="parent-theme"><?php printf( __( 'This is a child theme of %s.' ), '<strong>{{{ data.parent }}}</strong>' ); ?></p>
                     <# } #>
+
                     <# if ( data.tags ) { #>
-                        <p class="theme-tags"><span><?php _e( 'Tags:' ); ?></span> {{{ data.tags }}}</p>
+                        <p class="theme-tags"><span><?php _e( 'Tags:' ); ?></span> {{ data.tags }}</p>
                     <# } #>
                 </div>
             </div>
 
-            <div class="theme-actions">
-                <# if ( data.active ) { #>
-                    <button type="button" class="button button-primary customize-theme"><?php _e( 'Customize' ); ?></a>
-                <# } else if ( 'installed' === data.type ) { #>
-                    <?php if ( current_user_can( 'delete_themes' ) ) { ?>
-                        <# if ( data.actions && data.actions['delete'] ) { #>
-                            <a href="{{{ data.actions['delete'] }}}" data-slug="{{ data.id }}" class="button button-secondary delete-theme"><?php _e( 'Delete' ); ?></a>
-                        <# } #>
-                    <?php } ?>
-                    <button type="button" class="button button-primary preview-theme" data-slug="{{ data.id }}"><?php _e( 'Live Preview' ); ?></span>
-                <# } else { #>
-                    <button type="button" class="button theme-install" data-slug="{{ data.id }}"><?php _e( 'Install' ); ?></button>
-                    <button type="button" class="button button-primary theme-install preview" data-slug="{{ data.id }}"><?php _e( 'Install & Preview' ); ?></button>
-                <# } #>
-            </div>
+            <# if ( ! data.active ) { #>
+                <div class="theme-actions">
+                    <div class="inactive-theme">
+                        <?php
+                        /* translators: %s: Theme name */
+                        $aria_label = sprintf( __( 'Preview %s' ), '{{ data.name }}' );
+                        ?>
+                        <a href="<?php echo $preview_url; ?>" target="_top" class="button button-primary" aria-label="<?php echo esc_attr( $aria_label ); ?>"><?php _e( 'Live Preview' ); ?></a>
+                    </div>
+                </div>
+            <# } #>
         </div>
     </script>