WordPress.org

Make WordPress Core


Ignore:
Timestamp:
11/04/2016 03:53:01 PM (5 years ago)
Author:
helen
Message:

Customize: Revert theme install feature.

This is a great goal for core, and is close, but it is not in shape to be shipped for 4.7 and there is not enough time left in the development cycle to alter and polish sufficiently. There are bugs, but more than that, there are more fundamental questions around the use of existing UI, general UX, and how findable themes are (not) on the .org side.

see #37661.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/customize/class-wp-customize-theme-control.php

    r38889 r39140  
    6363     */
    6464    public function content_template() {
    65         /* translators: %s: theme name */
    66         $details_label = sprintf( __( 'Details for theme: %s' ), '{{ data.theme.name }}' );
    67         /* translators: %s: theme name */
    68         $customize_label = sprintf( __( 'Customize theme: %s' ), '{{ data.theme.name }}' );
    69         /* translators: %s: theme name */
    70         $preview_label = sprintf( __( 'Live preview theme: %s' ), '{{ data.theme.name }}' );
    71         /* translators: %s: theme name */
    72         $install_label = sprintf( __( 'Install and preview theme: %s' ), '{{ data.theme.name }}' );
     65        $current_url = set_url_scheme( 'http://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'] );
     66        $active_url  = esc_url( remove_query_arg( 'customize_theme', $current_url ) );
     67        $preview_url = esc_url( add_query_arg( 'customize_theme', '__THEME__', $current_url ) ); // Token because esc_url() strips curly braces.
     68        $preview_url = str_replace( '__THEME__', '{{ data.theme.id }}', $preview_url );
    7369        ?>
    74         <# if ( data.theme.active ) { #>
    75             <div class="theme active" tabindex="0" aria-describedby="{{ data.section }}-{{ data.theme.id }}-action {{ data.theme.id }}-name">
     70        <# if ( data.theme.isActiveTheme ) { #>
     71            <div class="theme active" tabindex="0" data-preview-url="<?php echo esc_attr( $active_url ); ?>" aria-describedby="{{ data.theme.id }}-action {{ data.theme.id }}-name">
    7672        <# } else { #>
    77             <div class="theme" tabindex="0" aria-describedby="{{ data.section }}-{{ data.theme.id }}-action {{ data.theme.id }}-name">
     73            <div class="theme" tabindex="0" data-preview-url="<?php echo esc_attr( $preview_url ); ?>" aria-describedby="{{ data.theme.id }}-action {{ data.theme.id }}-name">
    7874        <# } #>
    7975
    80             <# if ( data.theme.screenshot && data.theme.screenshot[0] ) { #>
     76            <# if ( data.theme.screenshot[0] ) { #>
    8177                <div class="theme-screenshot">
    8278                    <img data-src="{{ data.theme.screenshot[0] }}" alt="" />
     
    8682            <# } #>
    8783
    88             <span class="more-details theme-details" id="{{ data.section }}-{{ data.theme.id }}-action" aria-label="<?php echo esc_attr( $details_label ); ?>"><?php _e( 'Theme Details' ); ?></span>
    89 
    90 
    91             <# if ( 'installed' === data.theme.type && data.theme.hasUpdate ) { #>
    92                 <div class="update-message notice inline notice-warning notice-alt" data-slug="{{ data.theme.id }}"><p><?php printf( __( 'New version available. %s' ), '<button class="button-link update-theme" type="button">' . __( 'Update now' ) . '</button>' ); ?></p></div>
     84            <# if ( data.theme.isActiveTheme ) { #>
     85                <span class="more-details" id="{{ data.theme.id }}-action"><?php _e( 'Customize' ); ?></span>
     86            <# } else { #>
     87                <span class="more-details" id="{{ data.theme.id }}-action"><?php _e( 'Live Preview' ); ?></span>
    9388            <# } #>
    9489
    95             <# if ( data.theme.active ) { #>
    96                 <h3 class="theme-name" id="{{ data.section }}-{{ data.theme.id }}-name">
     90            <div class="theme-author"><?php printf( __( 'By %s' ), '{{ data.theme.author }}' ); ?></div>
     91
     92            <# if ( data.theme.isActiveTheme ) { #>
     93                <h3 class="theme-name" id="{{ data.theme.id }}-name">
    9794                    <?php
    9895                    /* translators: %s: theme name */
    99                     printf( __( '<span>Current:</span> %s' ), '{{ data.theme.name }}' );
     96                    printf( __( '<span>Active:</span> %s' ), '{{{ data.theme.name }}}' );
    10097                    ?>
    10198                </h3>
     99            <# } else { #>
     100                <h3 class="theme-name" id="{{ data.theme.id }}-name">{{{ data.theme.name }}}</h3>
    102101                <div class="theme-actions">
    103                     <button type="button" class="button button-primary customize-theme" aria-label="<?php echo esc_attr( $customize_label ); ?>"><?php _e( 'Customize' ); ?></button>
    104                 </div>
    105                 <div class="notice notice-success notice-alt"><p><?php _e( 'Installed' ); ?></p></div>
    106             <# } else if ( 'installed' === data.theme.type ) { #>
    107                 <h3 class="theme-name" id="{{ data.section }}-{{ data.theme.id }}-name">{{ data.theme.name }}</h3>
    108                 <div class="theme-actions">
    109                     <button type="button" class="button button-primary preview-theme" aria-label="<?php echo esc_attr( $preview_label ); ?>" data-slug="{{ data.theme.id }}"><?php _e( 'Live Preview' ); ?></span>
    110                 </div>
    111                 <div class="notice notice-success notice-alt"><p><?php _e( 'Installed' ); ?></p></div>
    112             <# } else { #>
    113                 <h3 class="theme-name" id="{{ data.section }}-{{ data.theme.id }}-name">{{ data.theme.name }}</h3>
    114                 <div class="theme-actions">
    115                     <button type="button" class="button button-primary theme-install preview" aria-label="<?php echo esc_attr( $install_label ); ?>" data-slug="{{ data.theme.id }}" data-name="{{ data.theme.name }}"><?php _e( 'Install & Preview' ); ?></button>
     102                    <button type="button" class="button theme-details"><?php _e( 'Theme Details' ); ?></button>
    116103                </div>
    117104            <# } #>
Note: See TracChangeset for help on using the changeset viewer.