Changeset 39146

Timestamp:

11/05/2016 12:44:28 AM (8 years ago)

Author:

davidakennedy

Message:

Twenty Seventeen: Fix playlists not rendering on blog/archive pages when using video or audio post format

TwentySeventeen attempts to highlight media found in post content by using get_media_embedded_in_content() to extract videos from the content and display their HTML differently. However, the HTML being generated by the playlist shortcode relies on JavaScript to update the video element with the markup needed to display the playlist properly. The get_media_embedded_in_content() function wasn't designed to handle this use case.

The patch looks for the presence of wp-playlist-script in the content and shows the standard content rather than trying to pluck the media elements from the content using get_media_embedded_in_content().

Props joemcgill.

Fixes #38390.

Location:

trunk/src/wp-content/themes/twentyseventeen/template-parts/post

Files:

• content-audio.php (modified) (1 diff)
• content-video.php (modified) (1 diff)

trunk/src/wp-content/themes/twentyseventeen/template-parts/post/content-audio.php

@@ -42 +42 @@
     <?php
         $content = apply_filters( 'the_content', get_the_content() );
-        $audio = get_media_embedded_in_content( $content, array( 'audio' ) );
+        $audio = false;
+
+        // Only get audio from the content if a playlist isn't present.
+        if ( false === strpos( $content, 'wp-playlist-script' ) ) {
+            $audio = get_media_embedded_in_content( $content, array( 'audio' ) );
+        }
+
     ?>
 

trunk/src/wp-content/themes/twentyseventeen/template-parts/post/content-video.php

@@ -41 +41 @@
     <?php
         $content = apply_filters( 'the_content', get_the_content() );
-        $video = get_media_embedded_in_content( $content, array( 'video', 'object', 'embed', 'iframe' ) );
+        $video = false;
+
+        // Only get video from the content if a playlist isn't present.
+        if ( false === strpos( $content, 'wp-playlist-script' ) ) {
+            $video = get_media_embedded_in_content( $content, array( 'video', 'object', 'embed', 'iframe' ) );
+        }
     ?>