WordPress.org

Make WordPress Core

Changeset 39147


Ignore:
Timestamp:
11/05/2016 04:27:13 PM (5 years ago)
Author:
afercia
Message:

Accessibility: Revert [38984] as it needs to be better communicated to plugin authors.

See #37513.

Location:
trunk/src/wp-includes
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/class-wp-admin-bar.php

    r38984 r39147  
    475475            return;
    476476
    477         $is_parent             = ! empty( $node->children );
    478         $has_link              = ! empty( $node->href );
    479         $is_root_top_item      = 'root-default' === $node->parent;
    480         $is_top_secondary_item = 'top-secondary' === $node->parent;
     477        $is_parent = ! empty( $node->children );
     478        $has_link  = ! empty( $node->href );
    481479
    482480        // Allow only numeric values, then casted to integers, and allow a tabindex value of `0` for a11y.
     
    484482        $aria_attributes = ( '' !== $tabindex ) ? ' tabindex="' . $tabindex . '"' : '';
    485483
    486         $menuclass = $arrow_right = '';
     484        $menuclass = '';
    487485
    488486        if ( $is_parent ) {
    489487            $menuclass = 'menupop ';
    490488            $aria_attributes .= ' aria-haspopup="true"';
    491         }
    492 
    493         // Print the right arrow icon for the primary menu children with children.
    494         if ( ! $is_root_top_item && ! $is_top_secondary_item && $is_parent ) {
    495             $arrow_right = '<span class="wp-admin-bar-arrow-right" aria-hidden="true"></span>';
    496489        }
    497490
     
    540533            endif;
    541534
    542             echo $arrow_right . $node->title;
     535            echo $node->title;
    543536
    544537            if ( $has_link ) :
  • trunk/src/wp-includes/css/admin-bar.css

    r38984 r39147  
    235235#wpadminbar > #wp-toolbar > #wp-admin-bar-root-default .ab-icon,
    236236#wpadminbar .ab-icon,
    237 #wpadminbar .ab-item:before,
    238 .wp-admin-bar-arrow-right {
     237#wpadminbar .ab-item:before {
    239238    position: relative;
    240239    float: left;
     
    314313}
    315314
    316 #wpadminbar .menupop .menupop > .ab-item .wp-admin-bar-arrow-right:before,
     315#wpadminbar .menupop .menupop > .ab-item:before,
    317316#wpadminbar .ab-top-secondary .menupop .menupop > .ab-item:before {
    318317    position: absolute;
     
    328327}
    329328
    330 #wpadminbar .menupop .menupop > .ab-item .wp-admin-bar-arrow-right:before {
     329#wpadminbar .menupop .menupop > .ab-item:before {
    331330    top: 1px;
    332     right: 10px;
    333     padding: 4px 0;
     331    right: 4px;
    334332    content: "\f139";
    335333    color: inherit;
Note: See TracChangeset for help on using the changeset viewer.