Changeset 39154 for trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

Timestamp:

11/08/2016 04:28:47 AM (10 years ago)

Author:

rmccue

Message:

REST API: Change attachment caption & description to objects.

Just like excerpt and content for regular posts, these have transformations applied that can make the content significantly different from the raw value.

Props jnylen0.
Fixes #38679.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (5 diffs)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -461 +461 @@
         public function test_create_item() {
                 wp_set_current_user( self::$author_id );
+
                 $request = new WP_REST_Request( 'POST', '/wp/v2/media' );
                 $request->set_header( 'Content-Type', 'image/jpeg' );
                 $request->set_header( 'Content-Disposition', 'attachment; filename=canola.jpg' );
+                $request->set_param( 'title', 'My title is very cool' );
+                $request->set_param( 'caption', 'This is a better caption.' );
+                $request->set_param( 'description', 'Without a description, my attachment is descriptionless.' );
+                $request->set_param( 'alt_text', 'Alt text is stored outside post schema.' );
+
                 $request->set_body( file_get_contents( $this->test_file ) );
                 $response = $this->server->dispatch( $request );
                 $data = $response->get_data();
+
                 $this->assertEquals( 201, $response->get_status() );
                 $this->assertEquals( 'image', $data['media_type'] );
+
+                $attachment = get_post( $data['id'] );
+                $this->assertEquals( 'My title is very cool', $data['title']['raw'] );
+                $this->assertEquals( 'My title is very cool', $attachment->post_title );
+                $this->assertEquals( 'This is a better caption.', $data['caption']['raw'] );
+                $this->assertEquals( 'This is a better caption.', $attachment->post_excerpt );
+                $this->assertEquals( 'Without a description, my attachment is descriptionless.', $data['description']['raw'] );
+                $this->assertEquals( 'Without a description, my attachment is descriptionless.', $attachment->post_content );
+                $this->assertEquals( 'Alt text is stored outside post schema.', $data['alt_text'] );
+                $this->assertEquals( 'Alt text is stored outside post schema.', get_post_meta( $attachment->ID, '_wp_attachment_image_alt', true ) );
         }
 
@@ -651 +668 @@
                 $this->assertEquals( 'My title is very cool', $data['title']['raw'] );
                 $this->assertEquals( 'My title is very cool', $attachment->post_title );
-                $this->assertEquals( 'This is a better caption.', $data['caption'] );
+                $this->assertEquals( 'This is a better caption.', $data['caption']['raw'] );
                 $this->assertEquals( 'This is a better caption.', $attachment->post_excerpt );
-                $this->assertEquals( 'Without a description, my attachment is descriptionless.', $data['description'] );
+                $this->assertEquals( 'Without a description, my attachment is descriptionless.', $data['description']['raw'] );
                 $this->assertEquals( 'Without a description, my attachment is descriptionless.', $attachment->post_content );
                 $this->assertEquals( 'Alt text is stored outside post schema.', $data['alt_text'] );
@@ -776 +793 @@
                 $this->assertArrayHasKey( 'alt_text', $properties );
                 $this->assertArrayHasKey( 'caption', $properties );
+                $this->assertArrayHasKey( 'raw', $properties['caption']['properties'] );
+                $this->assertArrayHasKey( 'rendered', $properties['caption']['properties'] );
                 $this->assertArrayHasKey( 'description', $properties );
+                $this->assertArrayHasKey( 'raw', $properties['description']['properties'] );
+                $this->assertArrayHasKey( 'rendered', $properties['description']['properties'] );
                 $this->assertArrayHasKey( 'comment_status', $properties );
                 $this->assertArrayHasKey( 'date', $properties );
@@ -795 +816 @@
                 $this->assertArrayHasKey( 'source_url', $properties );
                 $this->assertArrayHasKey( 'title', $properties );
+                $this->assertArrayHasKey( 'raw', $properties['title']['properties'] );
+                $this->assertArrayHasKey( 'rendered', $properties['title']['properties'] );
                 $this->assertArrayHasKey( 'type', $properties );
         }
@@ -892 +915 @@
                 parent::check_post_data( $attachment, $data, $context, $links );
 
+                $this->assertArrayNotHasKey( 'content', $data );
+                $this->assertArrayNotHasKey( 'excerpt', $data );
+
                 $this->assertEquals( get_post_meta( $attachment->ID, '_wp_attachment_image_alt', true ), $data['alt_text'] );
-                $this->assertEquals( $attachment->post_excerpt, $data['caption'] );
-                $this->assertEquals( $attachment->post_content, $data['description'] );
+                if ( 'edit' === $context ) {
+                        $this->assertEquals( $attachment->post_excerpt, $data['caption']['raw'] );
+                        $this->assertEquals( $attachment->post_content, $data['description']['raw'] );
+                } else {
+                        $this->assertFalse( isset( $data['caption']['raw'] ) );
+                        $this->assertFalse( isset( $data['description']['raw'] ) );
+                }
                 $this->assertTrue( isset( $data['media_details'] ) );