Changeset 39158

Timestamp:

11/08/2016 06:41:57 AM (8 years ago)

Author:

rmccue

Message:

REST API: Require 6 characters for comment email addresses.

The regular comments API requires 6 characters rather than 3, so we need to match this.

Props mangeshp, dd32.
Fixes #38506.

Location:

trunk

Files:

• src/wp-includes/rest-api.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api.php

@@ -1037 +1037 @@
 
             case 'email' :
-                if ( ! is_email( $value ) ) {
+                // is_email() checks for 3 characters (a@b), but
+                // wp_handle_comment_submission() requires 6 characters (a@b.co)
+                //
+                // https://core.trac.wordpress.org/ticket/38506
+                if ( ! is_email( $value ) || strlen( $value ) < 6 ) {
                     return new WP_Error( 'rest_invalid_email', __( 'The email address you provided is invalid.' ) );
                 }

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -907 +907 @@
 
         update_option( 'require_name_email', 0 );
+    }
+
+    public function test_create_comment_author_email_too_short() {
+        wp_set_current_user( 0 );
+
+        $params = array(
+            'post'         => self::$post_id,
+            'author_name'  => 'Homer J. Simpson',
+            'author_email' => 'a@b',
+            'content'      => 'in this house, we obey the laws of thermodynamics!',
+        );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/comments' );
+        $request->add_header( 'content-type', 'application/json' );
+        $request->set_body( wp_json_encode( $params ) );
+        $response = $this->server->dispatch( $request );
+
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+
+        $data = $response->get_data();
+        $this->assertArrayHasKey( 'author_email', $data['data']['params'] );
     }