Changeset 39174 for trunk/tests/phpunit/tests/term/wpInsertTerm.php

Timestamp:

11/09/2016 12:01:42 AM (10 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Utilise assertWPError() and assertNotWPError() in more places.

See #38716

File:

• trunk/tests/phpunit/tests/term/wpInsertTerm.php (modified) (10 diffs)

trunk/tests/phpunit/tests/term/wpInsertTerm.php

@@ -49 +49 @@
         $found = wp_insert_term( 'foo', 'bar' );
 
-        $this->assertTrue( is_wp_error( $found ) );
+        $this->assertWPError( $found );
         $this->assertSame( 'invalid_taxonomy', $found->get_error_code() );
     }
@@ -58 +58 @@
         remove_filter( 'pre_insert_term', array( $this, '_pre_insert_term_callback' ) );
 
-        $this->assertTrue( is_wp_error( $found ) );
+        $this->assertWPError( $found );
         $this->assertSame( 'custom_error', $found->get_error_code() );
     }
@@ -65 +65 @@
         $found = wp_insert_term( 0, 'post_tag' );
 
-        $this->assertTrue( is_wp_error( $found ) );
+        $this->assertWPError( $found );
         $this->assertSame( 'invalid_term_id', $found->get_error_code() );
     }
@@ -72 +72 @@
         $found = wp_insert_term( '  ', 'post_tag' );
 
-        $this->assertTrue( is_wp_error( $found ) );
+        $this->assertWPError( $found );
         $this->assertSame( 'empty_term_name', $found->get_error_code() );
     }
@@ -81 +81 @@
         ) );
 
-        $this->assertTrue( is_wp_error( $found ) );
+        $this->assertWPError( $found );
         $this->assertSame( 'missing_parent', $found->get_error_code() );
     }
@@ -171 +171 @@
         // Test an existing term name
         $term2 = self::factory()->tag->create( array( 'name' => 'Bozo' ) );
-        $this->assertTrue( is_wp_error( $term2 ) );
+        $this->assertWPError( $term2 );
         $this->assertNotEmpty( $term2->errors );
 
@@ -180 +180 @@
         $term6 = self::factory()->tag->create( array( 'name' => 'T$$$$' ) );
         $term7 = self::factory()->tag->create( array( 'name' => 'T$$$$' ) );
-        $this->assertTrue( is_wp_error( $term7 ) );
+        $this->assertWPError( $term7 );
         $this->assertNotEmpty( $term7->errors );
         $this->assertEquals( $term6, $term7->error_data['term_exists'] );
@@ -193 +193 @@
         $term11 = self::factory()->tag->create( array( 'name' => '$$$$' ) );
         $term12 = self::factory()->tag->create( array( 'name' => '$$$$' ) );
-        $this->assertTrue( is_wp_error( $term12 ) );
+        $this->assertWPError( $term12 );
         $this->assertNotEmpty( $term12->errors );
         $this->assertEquals( $term11, $term12->error_data['term_exists'] );
@@ -203 +203 @@
         $this->assertNotWPError( $term13 );
         $term14 = self::factory()->tag->create( array( 'name' => 'A' ) );
-        $this->assertTrue( is_wp_error( $term14 ) );
+        $this->assertWPError( $term14 );
         $term15 = self::factory()->tag->create( array( 'name' => 'A+', 'slug' => 'a' ) );
         $this->assertNotWPError( $term15 );
         $term16 = self::factory()->tag->create( array( 'name' => 'A+' ) );
-        $this->assertTrue( is_wp_error( $term16 ) );
+        $this->assertWPError( $term16 );
         $term17 = self::factory()->tag->create( array( 'name' => 'A++' ) );
         $this->assertNotWPError( $term17 );
@@ -213 +213 @@
         $this->assertNotWPError( $term18 );
         $term19 = self::factory()->tag->create( array( 'name' => 'A-' ) );
-        $this->assertTrue( is_wp_error( $term19 ) );
+        $this->assertWPError( $term19 );
         $term20 = self::factory()->tag->create( array( 'name' => 'A--' ) );
         $this->assertNotWPError( $term20 );