Changeset 39180 for trunk/tests/phpunit/tests/customize/manager.php

Timestamp:

11/09/2016 05:44:14 AM (10 years ago)

Author:

westonruter

Message:

Customize: Prevent post_content and post_name from being modified when trashing customize_changeset posts.

See #30937.
Fixes #38719.

File:

• trunk/tests/phpunit/tests/customize/manager.php (modified) (6 diffs)

trunk/tests/phpunit/tests/customize/manager.php

@@ -417 +417 @@
          */
         function test_save_changeset_post_without_theme_activation() {
+                global $wp_customize;
                 wp_set_current_user( self::$admin_user_id );
 
@@ -426 +427 @@
                 $uuid = wp_generate_uuid4();
 
-                $manager = new WP_Customize_Manager( array(
+                $wp_customize = $manager = new WP_Customize_Manager( array(
                         'changeset_uuid' => $uuid,
                 ) );
@@ -508 +509 @@
 
                 // Attempt a non-transactional/incremental update.
-                $manager = new WP_Customize_Manager( array(
+                $wp_customize = $manager = new WP_Customize_Manager( array(
                         'changeset_uuid' => $uuid,
                 ) );
@@ -544 +545 @@
                 $this->assertEquals( $customize_changeset_save_data_call_count + 1, $this->customize_changeset_save_data_call_count );
 
-                // Publish the changeset.
-                $manager = new WP_Customize_Manager( array( 'changeset_uuid' => $uuid ) );
+                // Publish the changeset: actions will be doubled since also trashed.
+                $expected_actions = array(
+                        'wp_trash_post' => 1,
+                        'clean_post_cache' => 2,
+                        'transition_post_status' => 2,
+                        'publish_to_trash' => 1,
+                        'trash_customize_changeset' => 1,
+                        'edit_post' => 2,
+                        'save_post_customize_changeset' => 2,
+                        'save_post' => 2,
+                        'wp_insert_post' => 2,
+                        'trashed_post' => 1,
+                );
+                $action_counts = array();
+                foreach ( array_keys( $expected_actions ) as $action_name ) {
+                        $action_counts[ $action_name ] = did_action( $action_name );
+                }
+
+                $wp_customize = $manager = new WP_Customize_Manager( array( 'changeset_uuid' => $uuid ) );
                 $manager->register_controls();
-                $GLOBALS['wp_customize'] = $manager;
+                $manager->add_setting( 'scratchpad', array(
+                        'type' => 'option',
+                        'capability' => 'exist',
+                ) );
+                $manager->get_setting( 'blogname' )->capability = 'exist';
+                wp_set_current_user( self::$subscriber_user_id );
                 $r = $manager->save_changeset_post( array(
                         'status' => 'publish',
@@ -554 +577 @@
                                         'value' => 'Do it live \o/',
                                 ),
+                                'scratchpad' => array(
+                                        'value' => '<script>console.info( "HELLO" )</script>',
+                                ),
                         ),
                 ) );
@@ -559 +585 @@
                 $this->assertEquals( 'Do it live \o/', get_option( 'blogname' ) );
                 $this->assertEquals( 'trash', get_post_status( $post_id ) ); // Auto-trashed.
+                $this->assertContains( '<script>', get_post( $post_id )->post_content );
+                $this->assertEquals( $manager->changeset_uuid(), get_post( $post_id )->post_name, 'Expected that the "__trashed" suffix to not be added.' );
+                wp_set_current_user( self::$admin_user_id );
+                $this->assertEquals( 'publish', get_post_meta( $post_id, '_wp_trash_meta_status', true ) );
+                $this->assertTrue( is_numeric( get_post_meta( $post_id, '_wp_trash_meta_time', true ) ) );
+
+                foreach ( array_keys( $expected_actions ) as $action_name ) {
+                        $this->assertEquals( $expected_actions[ $action_name ] + $action_counts[ $action_name ], did_action( $action_name ), "Action: $action_name" );
+                }
 
                 // Test revisions.
                 add_post_type_support( 'customize_changeset', 'revisions' );
                 $uuid = wp_generate_uuid4();
-                $manager = new WP_Customize_Manager( array( 'changeset_uuid' => $uuid ) );
+                $wp_customize = $manager = new WP_Customize_Manager( array( 'changeset_uuid' => $uuid ) );
                 $manager->register_controls();
-                $GLOBALS['wp_customize'] = $manager;
 
                 $manager->set_post_value( 'blogname', 'Hello Surface' );