Changeset 39183

Timestamp:

11/09/2016 04:12:35 PM (9 years ago)

Author:

karmatosed

Message:

Twenty Seventeen: Fixes focused controls hidden by top menu.

When a page is scrolled, the top nav menu became fixed. This resolves that.

Props afercia, Fencer04, davidakennedy
Fixes #38476

Location:

trunk/src/wp-content/themes/twentyseventeen

Files:

• assets/js/global.js (modified) (1 diff)
• functions.php (modified) (1 diff)

trunk/src/wp-content/themes/twentyseventeen/assets/js/global.js

@@ -28 +28 @@
 
     /**
+     * Ensure the sticky navigation doesn't cover current focused links
+     */
+    $( '#content a, #colophon a' ).focus( function() {
+        if ( $navigation.hasClass( 'site-navigation-fixed' ) ) {
+            var windowScrollTop = $( window ).scrollTop(),
+                fixedNavHeight = $navigation.height(),
+                itemScrollTop = $( this ).offset().top,
+                offsetDiff = itemScrollTop - windowScrollTop;
+
+            // Account for Admin bar.
+            if ( $( '#wpadminbar' ).length ) {
+                offsetDiff -= $( '#wpadminbar' ).height();
+            }
+
+            if ( offsetDiff < fixedNavHeight ) {
+                $( window ).scrollTo( itemScrollTop - ( fixedNavHeight + 50 ), 600);
+            };
+        }
+    } );
+
+    /**
      * Sets properties of navigation
      */

trunk/src/wp-content/themes/twentyseventeen/functions.php

@@ -380 +380 @@
     wp_enqueue_script( 'twentyseventeen-global', get_theme_file_uri( '/assets/js/global.js' ), array( 'jquery' ), '1.0', true );
 
+    wp_enqueue_script( 'jquery-scrollto', get_theme_file_uri( '/assets/js/jquery.scrollTo.js' ), array( 'jquery' ), '2.1.2', true );
+
     wp_localize_script( 'twentyseventeen-skip-link-focus-fix', 'twentyseventeenScreenReaderText', $twentyseventeen_l10n );
 
     if ( is_singular() && comments_open() && get_option( 'thread_comments' ) ) {
         wp_enqueue_script( 'comment-reply' );
-    }
-
-    // Scroll effects (only loaded on front page).
-    if ( is_front_page() ) {
-        wp_enqueue_script( 'jquery-scrollto', get_template_directory_uri() . '/assets/js/jquery.scrollTo.js', array( 'jquery' ), '2.1.2', true );
     }
 }