Changeset 39189 for trunk/tests/phpunit/tests/xmlrpc/wp/getComment.php

Timestamp:

11/10/2016 01:53:08 AM (4 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Re-use a bunch of fixtures in test classes for user and XMLRPC tests.

Shaves a couple of seconds off of the tests.

See #30017, #38716

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getComment.php (modified) (6 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getComment.php

@@ -5 +5 @@
  */
 class Tests_XMLRPC_wp_getComment extends WP_XMLRPC_UnitTestCase {
-    var $post_id;
-    var $parent_comment_id;
-    var $parent_comment_data;
-    var $child_comment_id;
-    var $child_comment_data;
+    protected static $post_id;
+    protected static $parent_comment_id;
+    protected static $parent_comment_data;
+    protected static $child_comment_id;
+    protected static $child_comment_data;
 
-    function setUp() {
-        parent::setUp();
+    public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+        self::$post_id = $factory->post->create();
 
-        $this->post_id = self::factory()->post->create();
-
-        $this->parent_comment_data = array(
-            'comment_post_ID' => $this->post_id,
+        self::$parent_comment_data = array(
+            'comment_post_ID' => self::$post_id,
             'comment_author' => 'Test commenter',
             'comment_author_url' => 'http://example.com/',
@@ -23 +21 @@
             'comment_content' => rand_str( 100 ),
         );
-        $this->parent_comment_id = wp_insert_comment( $this->parent_comment_data );
+        self::$parent_comment_id = wp_insert_comment( self::$parent_comment_data );
 
-        $this->child_comment_data = array(
-            'comment_post_ID' => $this->post_id,
+        self::$child_comment_data = array(
+            'comment_post_ID' => self::$post_id,
             'comment_author' => 'Test commenter 2',
             'comment_author_url' => 'http://example.org/',
             'comment_author_email' => 'example@example.org',
-            'comment_parent' => $this->parent_comment_id,
+            'comment_parent' => self::$parent_comment_id,
             'comment_content' => rand_str( 100 )
         );
-        $this->child_comment_id = wp_insert_comment( $this->child_comment_data );
+        self::$child_comment_id = wp_insert_comment( self::$child_comment_data );
     }
 
     function test_invalid_username_password() {
-        $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'username', 'password', $this->parent_comment_id ) );
+        $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'username', 'password', self::$parent_comment_id ) );
         $this->assertInstanceOf( 'IXR_Error', $result );
         $this->assertEquals( 403, $result->code );
@@ -45 +43 @@
         $this->make_user_by_role( 'contributor' );
 
-        $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'contributor', 'contributor', $this->parent_comment_id ) );
+        $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'contributor', 'contributor', self::$parent_comment_id ) );
         $this->assertInstanceOf( 'IXR_Error', $result );
         $this->assertEquals( 403, $result->code );
@@ -53 +51 @@
         $this->make_user_by_role( 'editor' );
 
-        $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'editor', 'editor', $this->parent_comment_id ) );
+        $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'editor', 'editor', self::$parent_comment_id ) );
         $this->assertNotInstanceOf( 'IXR_Error', $result );
 
@@ -77 +75 @@
         $this->assertStringMatchesFormat( '%d', $result['parent'] );
         $this->assertStringMatchesFormat( '%d', $result['post_id'] );
-        $this->assertEquals( $this->parent_comment_id, $result['comment_id'] );
+        $this->assertEquals( self::$parent_comment_id, $result['comment_id'] );
         $this->assertEquals( 0, $result['parent'] );
-        $this->assertEquals( $this->parent_comment_data['comment_content'], $result['content'] );
-        $this->assertEquals( $this->post_id, $result['post_id'] );
-        $this->assertEquals( $this->parent_comment_data['comment_author'], $result['author'] );
-        $this->assertEquals( $this->parent_comment_data['comment_author_url'], $result['author_url'] );
-        $this->assertEquals( $this->parent_comment_data['comment_author_email'], $result['author_email'] );
+        $this->assertEquals( self::$parent_comment_data['comment_content'], $result['content'] );
+        $this->assertEquals( self::$post_id, $result['post_id'] );
+        $this->assertEquals( self::$parent_comment_data['comment_author'], $result['author'] );
+        $this->assertEquals( self::$parent_comment_data['comment_author_url'], $result['author_url'] );
+        $this->assertEquals( self::$parent_comment_data['comment_author_email'], $result['author_email'] );
     }
 
@@ -89 +87 @@
         $this->make_user_by_role( 'editor' );
 
-        $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'editor', 'editor', $this->child_comment_id ) );
+        $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'editor', 'editor', self::$child_comment_id ) );
         $this->assertNotInstanceOf( 'IXR_Error', $result );
 
-        $this->assertEquals( $this->child_comment_id, $result['comment_id'] );
-        $this->assertEquals( $this->parent_comment_id, $result['parent'] );
+        $this->assertEquals( self::$child_comment_id, $result['comment_id'] );
+        $this->assertEquals( self::$parent_comment_id, $result['parent'] );
     }