Changeset 39199

Timestamp:

11/10/2016 10:42:38 PM (9 years ago)

Author:

westonruter

Message:

Customize: Prevent previewer from appearing to freeze when refreshing too fast.

Fixes race condition issue where a previous iframe fails to get destroyed, leaving a iframe pending loading persistently shown.

Props nikeo, westonruter.
Fixes #38728.

File:

• trunk/src/wp-admin/js/customize-controls.js (modified) (2 diffs)

trunk/src/wp-admin/js/customize-controls.js

@@ -3931 +3931 @@
 
             previewer.loading.done( function( readyData ) {
-                var loadingFrame = this, previousPreview, onceSynced;
-
-                previousPreview = previewer.preview;
+                var loadingFrame = this, onceSynced;
+
                 previewer.preview = loadingFrame;
                 previewer.targetWindow( loadingFrame.targetWindow() );
@@ -3940 +3939 @@
                 onceSynced = function() {
                     loadingFrame.unbind( 'synced', onceSynced );
-                    if ( previousPreview ) {
-                        previousPreview.destroy();
+                    if ( previewer._previousPreview ) {
+                        previewer._previousPreview.destroy();
                     }
+                    previewer._previousPreview = previewer.preview;
                     previewer.deferred.active.resolve();
                     delete previewer.loading;