Changeset 39210

Timestamp:

11/13/2016 07:41:30 AM (8 years ago)

Author:

dd32

Message:

Posts, Post Types: Fix Quick Edit to correctly set the page template for non-hierarchical post types.

Props dd32, swissspidy.
Fixes #38655.

Location:

trunk/src/wp-admin

Files:

• includes/class-wp-posts-list-table.php (modified) (1 diff)
• includes/template.php (modified) (1 diff)
• js/inline-edit-post.js (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1556 +1556 @@
                 ?>
                 <option value="default"><?php echo esc_html( $default_title ); ?></option>
-                <?php page_template_dropdown( $post->page_template, $screen->post_type ) ?>
+                <?php page_template_dropdown( '', $screen->post_type ) ?>
             </select>
         </label>

trunk/src/wp-admin/includes/template.php

@@ -298 +298 @@
     }
 
-    echo '<div class="page_template">' . esc_html( $post->page_template ) . '</div>';
+    echo '<div class="page_template">' . ( $post->page_template ? esc_html( $post->page_template ) : 'default' ) . '</div>';
 
     if ( post_type_supports( $post->post_type, 'page-attributes' ) ) {

trunk/src/wp-admin/js/inline-edit-post.js

@@ -130 +130 @@
         }
 
-        fields = ['post_title', 'post_name', 'post_author', '_status', 'jj', 'mm', 'aa', 'hh', 'mn', 'ss', 'post_password', 'post_format', 'menu_order'];
+        fields = ['post_title', 'post_name', 'post_author', '_status', 'jj', 'mm', 'aa', 'hh', 'mn', 'ss', 'post_password', 'post_format', 'menu_order', 'page_template'];
         if ( t.type === 'page' ) {
-            fields.push('post_parent', 'page_template');
+            fields.push('post_parent');
         }