Changeset 39214

Timestamp:

11/13/2016 06:59:21 PM (8 years ago)

Author:

westonruter

Message:

Customize: Prevent the "Hide Controls" button label from overrunning the device preview buttons.

Adds translation context for "Hide Controls" strings so translators can supply shorter strings where space is constrained. Adds styles to fade-out long the "Hide Controls" label where it would run into the device preview buttons.

Props westonruter, ocean90.
Fixes #38762.

Location:

trunk/src

Files:

• wp-admin/css/themes.css (modified) (2 diffs)
• wp-admin/customize.php (modified) (1 diff)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/wp-admin/css/themes.css

@@ -1522 +1522 @@
     -webkit-border-radius: 0 !important;
     border-radius: 0 !important;
+    z-index: -1; /* Below device buttons */
 }
 
@@ -1625 +1626 @@
 .wp-full-overlay-footer .devices {
     float: right;
+    background: #eee;
+    -webkit-box-shadow: -20px 0 10px -5px #eee;
+    box-shadow: -20px 0 10px -5px #eee;
 }
 

trunk/src/wp-admin/customize.php

@@ -192 +192 @@
             </div>
             <?php endif; ?>
-            <button type="button" class="collapse-sidebar button" aria-expanded="true" aria-label="<?php esc_attr_e( 'Hide Controls' ); ?>">
+            <button type="button" class="collapse-sidebar button" aria-expanded="true" aria-label="<?php echo esc_attr( _x( 'Hide Controls', 'label for hide controls button without length constraints' ) ); ?>">
                 <span class="collapse-sidebar-arrow"></span>
-                <span class="collapse-sidebar-label"><?php _e( 'Hide Controls' ); ?></span>
+                <span class="collapse-sidebar-label"><?php _ex( 'Hide Controls', 'short (~12 characters) label for hide controls button' ); ?></span>
             </button>
         </div>

trunk/src/wp-includes/script-loader.php

@@ -468 +468 @@
         'previewIframeTitle' => __( 'Site Preview' ),
         'loginIframeTitle'   => __( 'Session expired' ),
-        'collapseSidebar'    => __( 'Hide Controls' ),
-        'expandSidebar'      => __( 'Show Controls' ),
+        'collapseSidebar'    => _x( 'Hide Controls', 'label for hide controls button without length constraints' ),
+        'expandSidebar'      => _x( 'Show Controls', 'label for hide controls button without length constraints' ),
         'untitledBlogName'   => __( '(Untitled)' ),
         // Used for overriding the file types allowed in plupload.