Changeset 39247

Timestamp:

11/15/2016 04:00:41 PM (4 years ago)

Author:

afercia

Message:

Accessibility: Improve the Post Attributes meta box fields labels.

With [38951] the support for custom page templates has been extended to all post
types. By making the visible meta box titles real labels, accessibility improves
for all users and form fields have meaningful labels.

Fixes #38790.

Location:

trunk/src/wp-admin

Files:

• css/edit.css (modified) (1 diff)
• includes/meta-boxes.php (modified) (4 diffs)

trunk/src/wp-admin/css/edit.css

@@ -627 +627 @@
 .ie8 #poststuff .inside #page_template {
     width: 250px;
+}
+
+.post-attributes-label-wrapper {
+    margin-bottom: 0.5em;
+}
+
+.post-attributes-label {
+    vertical-align: baseline;
+    font-weight: 600;
 }
 

trunk/src/wp-admin/includes/meta-boxes.php

@@ -814 +814 @@
         if ( ! empty($pages) ) :
 ?>
-<p><strong><?php _e('Parent') ?></strong></p>
-<label class="screen-reader-text" for="parent_id"><?php _e('Parent') ?></label>
+<p class="post-attributes-label-wrapper"><label class="post-attributes-label" for="parent_id"><?php _e( 'Parent' ); ?></label></p>
 <?php echo $pages; ?>
 <?php
@@ -824 +823 @@
         $template = ! empty( $post->page_template ) ? $post->page_template : false;
         ?>
-<p><strong><?php _e('Template') ?></strong><?php
+<p class="post-attributes-label-wrapper"><label class="post-attributes-label" for="page_template"><?php _e( 'Template' ); ?></label><?php
     /**
-     * Fires immediately after the heading inside the 'Template' section
+     * Fires immediately after the label inside the 'Template' section
      * of the 'Page Attributes' meta box.
      *
@@ -836 +835 @@
     do_action( 'page_attributes_meta_box_template', $template, $post );
 ?></p>
-<label class="screen-reader-text" for="page_template">
-    <?php
-    $post_type_object = get_post_type_object( $post->post_type );
-    echo esc_html( $post_type_object->labels->attributes );
-    ?>
-</label>
 <select name="page_template" id="page_template">
 <?php
@@ -860 +853 @@
 <?php endif; ?>
 <?php if ( post_type_supports( $post->post_type, 'page-attributes' ) ) : ?>
-<p><strong><?php _e('Order') ?></strong></p>
-<p><label class="screen-reader-text" for="menu_order"><?php _e('Order') ?></label><input name="menu_order" type="text" size="4" id="menu_order" value="<?php echo esc_attr($post->menu_order) ?>" /></p>
+<p class="post-attributes-label-wrapper"><label class="post-attributes-label" for="menu_order"><?php _e( 'Order' ); ?></label></p>
+<input name="menu_order" type="text" size="4" id="menu_order" value="<?php echo esc_attr( $post->menu_order ); ?>" />
 <?php if ( 'page' == $post->post_type && get_current_screen()->get_help_tabs() ) : ?>
 <p><?php _e( 'Need help? Use the Help tab above the screen title.' ); ?></p>