Changeset 39270

Timestamp:

11/16/2016 08:36:40 PM (8 years ago)

Author:

westonruter

Message:

Customize: Prevent edit shortcut buttons from being inserted into container elements in the head or into elements which should not get interactive children.

See #27403, #38672.
Fixes #38830.

File:

• trunk/src/wp-includes/js/customize-selective-refresh.js (modified) (1 diff)

trunk/src/wp-includes/js/customize-selective-refresh.js

@@ -110 +110 @@
          */
         createEditShortcutForPlacement: function( placement ) {
-            var partial = this, $shortcut, $placementContainer;
+            var partial = this, $shortcut, $placementContainer, illegalAncestorSelector, illegalContainerSelector;
             if ( ! placement.container ) {
                 return;
             }
             $placementContainer = $( placement.container );
-            if ( ! $placementContainer.length ) {
+            illegalAncestorSelector = 'head';
+            illegalContainerSelector = 'area, audio, base, bdi, bdo, br, button, canvas, col, colgroup, command, datalist, embed, head, hr, html, iframe, img, input, keygen, label, link, map, math, menu, meta, noscript, object, optgroup, option, param, progress, rp, rt, ruby, script, select, source, style, svg, table, tbody, textarea, tfoot, thead, title, tr, track, video, wbr';
+            if ( ! $placementContainer.length || $placementContainer.is( illegalContainerSelector ) || $placementContainer.closest( illegalAncestorSelector ).length ) {
                 return;
             }