Changeset 39290

Timestamp:

11/18/2016 06:36:10 PM (8 years ago)

Author:

rachelbaker

Message:

REST API: On comment create, return an error if the type property is set to anything other than comment.

Of the default comment_types, only comments are expected to be created via the REST API endpoint. Comments do not have registered types the way that Posts do, so we do not have a method to accurately check permissions for arbitrary comment types.

Props dd32, boonebgorges, rachelbaker.
Fixes #38820.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -432 +432 @@
         if ( is_wp_error( $prepared_comment ) ) {
             return $prepared_comment;
+        }
+
+        // Do not allow comments to be created with a non-default type.
+        if ( ! empty( $request['type'] ) && 'comment' !== $request['type'] ) {
+            return new WP_Error( 'rest_invalid_comment_type', __( 'Cannot create a comment with that type.' ), array( 'status' => 400 ) );
         }
 

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -1033 +1033 @@
         $collection_data = $collection_response->get_data();
         $this->assertEquals( $comment_id, $collection_data[0]['id'] );
+    }
+
+    /**
+     * @ticket 38820
+     */
+    public function test_create_comment_with_invalid_type() {
+        $post_id = $this->factory->post->create();
+        wp_set_current_user( self::$admin_id );
+
+        $params = array(
+            'post'    => $post_id,
+            'author'       => self::$admin_id,
+            'author_name'  => 'Comic Book Guy',
+            'author_email' => 'cbg@androidsdungeon.com',
+            'author_url'   => 'http://androidsdungeon.com',
+            'content' => 'Worst Comment Ever!',
+            'date'    => '2014-11-07T10:14:25',
+            'type' => 'foo',
+        );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/comments' );
+        $request->add_header( 'content-type', 'application/json' );
+        $request->set_body( wp_json_encode( $params ) );
+
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_comment_type', $response, 400 );
     }
 
@@ -2219 +2245 @@
 
         $this->assertEquals( '127.0.0.1', $properties['author_ip']['default'] );
+
+        $this->assertEquals( 'comment', $properties['type']['default'] );
+
         $this->assertEquals( 0, $properties['parent']['default'] );
         $this->assertEquals( 0, $properties['post']['default'] );