Changeset 39292 for trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

Timestamp:

11/18/2016 06:52:19 PM (8 years ago)

Author:

rachelbaker

Message:

REST API: Remove the karma property and query parameter from the Comments endpoints.

WordPress has not used the karma property internally for the past 8 years. There is no need to expose it in the REST API endpoints. Sites that use karma can include it using the register_rest_field() function.

Props dd32, danielbachhuber.
Fixes #38821.

File:

• trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (9 diffs)

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -136 +136 @@
             'exclude',
             'include',
-            'karma',
             'offset',
             'order',
@@ -1162 +1161 @@
     }
 
-    public function test_create_comment_karma_without_permission() {
-        wp_set_current_user( self::$subscriber_id );
-
-        $params = array(
-            'post'         => self::$post_id,
-            'author_name'  => 'Homer Jay Simpson',
-            'author_email' => 'chunkylover53@aol.com',
-            'author_url'   => 'http://compuglobalhypermeganet.com',
-            'content'      => 'Here\’s to alcohol: the cause of, and solution to, all of life\’s problems.',
-            'author'       => self::$subscriber_id,
-            'karma'        => 100,
-        );
-
-        $request = new WP_REST_Request( 'POST', '/wp/v2/comments' );
-        $request->add_header( 'content-type', 'application/json' );
-        $request->set_body( wp_json_encode( $params ) );
-        $response = $this->server->dispatch( $request );
-
-        $this->assertErrorResponse( 'rest_comment_invalid_karma', $response, 403 );
-    }
-
     public function test_create_comment_invalid_post() {
         wp_set_current_user( self::$subscriber_id );
@@ -1193 +1171 @@
             'content'      => 'Here\’s to alcohol: the cause of, and solution to, all of life\’s problems.',
             'author'       => self::$subscriber_id,
-        );
-
-        $request = new WP_REST_Request( 'POST', '/wp/v2/comments' );
-        $request->add_header( 'content-type', 'application/json' );
-        $request->set_body( wp_json_encode( $params ) );
-        $response = $this->server->dispatch( $request );
-
-        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
-    }
-
-    public function test_create_comment_karma_invalid_value() {
-        wp_set_current_user( self::$subscriber_id );
-
-        $params = array(
-            'post'       => self::$post_id,
-            'author_name'  => 'Homer Jay Simpson',
-            'author_email' => 'chunkylover53@aol.com',
-            'author_url'   => 'http://compuglobalhypermeganet.com',
-            'content'     => 'Here\’s to alcohol: the cause of, and solution to, all of life\’s problems.',
-            'author'       => self::$subscriber_id,
-            'karma'     => 'themostkarmaever',
         );
 
@@ -1650 +1607 @@
             'content'      => 'Testing.',
             'date'         => '2014-11-07T10:14:25',
-            'karma'        => 100,
             'post'         => $post_id,
         );
@@ -1669 +1625 @@
         $this->assertEquals( $params['author_ip'], $comment['author_ip'] );
         $this->assertEquals( $params['post'], $comment['post'] );
-        $this->assertEquals( $params['karma'], $comment['karma'] );
 
         $this->assertEquals( mysql_to_rfc3339( $updated->comment_date ), $comment['date'] );
@@ -2224 +2179 @@
         $data = $response->get_data();
         $properties = $data['schema']['properties'];
-        $this->assertEquals( 18, count( $properties ) );
+        $this->assertEquals( 17, count( $properties ) );
         $this->assertArrayHasKey( 'id', $properties );
         $this->assertArrayHasKey( 'author', $properties );
@@ -2236 +2191 @@
         $this->assertArrayHasKey( 'date', $properties );
         $this->assertArrayHasKey( 'date_gmt', $properties );
-        $this->assertArrayHasKey( 'karma', $properties );
         $this->assertArrayHasKey( 'link', $properties );
         $this->assertArrayHasKey( 'meta', $properties );
@@ -2383 +2337 @@
             $this->assertEquals( $comment->comment_agent, $data['author_user_agent'] );
             $this->assertEquals( $comment->comment_content, $data['content']['raw'] );
-            $this->assertEquals( $comment->comment_karma, $data['karma'] );
         }
 
@@ -2391 +2344 @@
             $this->assertArrayNotHasKey( 'author_user_agent', $data );
             $this->assertArrayNotHasKey( 'raw', $data['content'] );
-            $this->assertArrayNotHasKey( 'karma', $data );
         }
     }