Changeset 39303

Timestamp:

11/18/2016 10:21:19 PM (10 years ago)

Author:

mikeschroder

Message:

Media: Allow override of PDF setup for multiple pages or DPI.

After [39187], WordPress started loading only the first page of a PDF.

This is appropriate for performance, but made it impossible to
write plugins that read other pages without overriding load().

Introduces WP_Image_Editor_Imagick->pdf_setup(), to allow an override
to change WordPress' rendering DPI defaults or which pages are loaded.

Fixes #38832. See #38522, #31050.
Props markoheijnen, joemcgill, mikeschroder.

File:

• trunk/src/wp-includes/class-wp-image-editor-imagick.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-image-editor-imagick.php

@@ -150 +150 @@
                         $filename = $this->file;
 
-                        // By default, PDFs are rendered in a very low resolution.
-                        // We want the thumbnail to be readable, so increase the rendering dpi.
                         if ( 'pdf' == strtolower( $file_parts['extension'] ) ) {
-                                $this->image->setResolution( 128, 128 );
-
-                                // Only load the first page.
-                                $filename .= '[0]';
+                                $filename = $this->pdf_setup();
                         }
 
@@ -744 +739 @@
         }
 
+        /**
+         * Sets up Imagick for PDF processing.
+         * Increases rendering DPI and only loads first page.
+         *
+         * @since 4.7.0
+         * @access protected
+         *
+         * @return string|WP_Error File to load or WP_Error on failure.
+         */
+        protected function pdf_setup() {
+                try {
+                        // By default, PDFs are rendered in a very low resolution.
+                        // We want the thumbnail to be readable, so increase the rendering DPI.
+                        $this->image->setResolution( 128, 128 );
+
+                        // Only load the first page.
+                        return $this->file . '[0]';
+                }
+                catch ( Exception $e ) {
+                        return new WP_Error( 'pdf_setup_failed', $e->getMessage(), $this->file );
+                }
+        }
+
 }