Changeset 39318

Timestamp:

11/19/2016 05:59:12 AM (10 years ago)

Author:

westonruter

Message:

Customize: Ensure WP_Customize_Setting::value() returns previewed value for custom types utilizing the customize_value_{$id_base} filter.

Fixes #38864.

Location:

trunk

Files:

• src/wp-includes/class-wp-customize-setting.php (modified) (1 diff)
• src/wp-includes/customize/class-wp-customize-custom-css-setting.php (modified) (1 diff)
• tests/phpunit/tests/customize/setting.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-customize-setting.php

@@ -697 +697 @@
 
                 if ( ! $is_core_type && ! $this->is_multidimensional_aggregated ) {
+
+                        // Use post value if previewed and a post value is present.
+                        if ( $this->is_previewed ) {
+                                $value = $this->post_value( null );
+                                if ( null !== $value ) {
+                                        return $value;
+                                }
+                        }
+
                         $value = $this->get_root_value( $this->default );
 

trunk/src/wp-includes/customize/class-wp-customize-custom-css-setting.php

@@ -133 +133 @@
          */
         public function value() {
+                if ( $this->is_previewed ) {
+                        $post_value = $this->post_value( null );
+                        if ( null !== $post_value ) {
+                                return $post_value;
+                        }
+                }
                 $id_base = $this->id_data['base'];
-                if ( $this->is_previewed && null !== $this->post_value( null ) ) {
-                        return $this->post_value();
-                }
                 $value = '';
                 $post = wp_get_custom_css_post( $this->stylesheet );

trunk/tests/phpunit/tests/customize/setting.php

@@ -396 +396 @@
                 $this->assertEquals( $post_data_overrides[ $name ], $setting->value() );
 
+                // Custom type that does not handle supplying the post value from the customize_value_{$id_base} filter.
+                $setting_id = 'custom_without_previewing_value_filter';
+                $setting = $this->manager->add_setting( $setting_id, array(
+                        'type' => 'custom_preview_test',
+                        'default' => 123,
+                        'sanitize_callback' => array( $this->manager->nav_menus, 'intval_base10' ),
+                ) );
+                $this->assertSame( 123, $setting->value() );
+                $this->manager->set_post_value( $setting_id, '456' );
+                $setting->preview();
+                $this->assertSame( 456, $setting->value() );
+
                 unset( $this->custom_type_data_previewed, $this->custom_type_data_saved );
         }