Changeset 39330 for trunk/src/wp-includes/class-wp-locale-switcher.php

Timestamp:

11/21/2016 04:06:38 PM (8 years ago)

Author:

ocean90

Message:

I18N: Add an additional caching layer for _load_textdomain_just_in_time().

Previously, if no translation files exist for a text domain, _load_textdomain_just_in_time() went through the entire process each time it was called. This results in an increased call to get_locale() and its locale filter.
This change splits the logic into _get_path_to_translation() and _get_path_to_translation_from_lang_dir(). The former, which is used by _load_textdomain_just_in_time(), caches the result of the latter. It also removes some non-working code from WP_Locale_Switcher::load_translations().

Props jrf, swissspidy, sharkomatic, ocean90.
Fixes #37997.

File:

• trunk/src/wp-includes/class-wp-locale-switcher.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-locale-switcher.php

@@ -203 +203 @@
             }
 
-            $mofile = $l10n[ $domain ]->get_filename();
-
             unload_textdomain( $domain );
-
-            if ( $mofile ) {
-                load_textdomain( $domain, $mofile );
-            }
-
             get_translations_for_domain( $domain );
         }
@@ -229 +222 @@
      */
     private function change_locale( $locale ) {
+        // Reset translation availability information.
+        _get_path_to_translation( null, true );
+
         $this->load_translations( $locale );