Changeset 39330 for trunk/tests/phpunit/tests/l10n/loadTextdomainJustInTime.php

Timestamp:

11/21/2016 04:06:38 PM (8 years ago)

Author:

ocean90

Message:

I18N: Add an additional caching layer for _load_textdomain_just_in_time().

Previously, if no translation files exist for a text domain, _load_textdomain_just_in_time() went through the entire process each time it was called. This results in an increased call to get_locale() and its locale filter.
This change splits the logic into _get_path_to_translation() and _get_path_to_translation_from_lang_dir(). The former, which is used by _load_textdomain_just_in_time(), caches the result of the latter. It also removes some non-working code from WP_Locale_Switcher::load_translations().

Props jrf, swissspidy, sharkomatic, ocean90.
Fixes #37997.

File:

• trunk/tests/phpunit/tests/l10n/loadTextdomainJustInTime.php (modified) (6 diffs)

trunk/tests/phpunit/tests/l10n/loadTextdomainJustInTime.php

@@ -9 +9 @@
     protected $theme_root;
     protected static $user_id;
+    private $locale_count;
 
     public static function wpSetUpBeforeClass( $factory ) {
@@ -22 +23 @@
         $this->theme_root = DIR_TESTDATA . '/themedir1';
         $this->orig_theme_dir = $GLOBALS['wp_theme_directories'];
+        $this->locale_count = 0;
 
         // /themes is necessary as theme.php functions assume /themes is the root if there is only one root.
@@ -32 +34 @@
         unset( $GLOBALS['l10n'] );
         unset( $GLOBALS['l10n_unloaded'] );
+        _get_path_to_translation( null, true );
     }
 
@@ -43 +46 @@
         unset( $GLOBALS['l10n'] );
         unset( $GLOBALS['l10n_unloaded'] );
+        _get_path_to_translation( null, true );
 
         parent::tearDown();
@@ -161 +165 @@
 
         $this->assertSame( 'Das ist ein Dummy Plugin', $expected );
+    }
+
+    /**
+     * @ticket 37997
+     */
+    public function test_plugin_translation_after_switching_locale_twice() {
+        require_once DIR_TESTDATA . '/plugins/internationalized-plugin.php';
+
+        switch_to_locale( 'de_DE' );
+        $expected_de_DE = i18n_plugin_test();
+
+        switch_to_locale( 'es_ES' );
+        $expected_es_ES = i18n_plugin_test();
+
+        restore_current_locale();
+
+        $this->assertSame( 'Das ist ein Dummy Plugin', $expected_de_DE );
+        $this->assertSame( 'This is a dummy plugin', $expected_es_ES );
     }
 
@@ -213 +235 @@
         $this->assertSame( 'Das ist ein Dummy Theme', $expected );
     }
+
+    /**
+     * @ticket 37997
+     */
+    public function test_get_locale_is_called_only_once_per_textdomain() {
+        $textdomain = 'foo-bar-baz';
+
+        add_filter( 'locale', array( $this, '_filter_locale_count' ) );
+
+        __( 'Foo', $textdomain );
+        __( 'Bar', $textdomain );
+        __( 'Baz', $textdomain );
+        __( 'Foo Bar', $textdomain );
+        __( 'Foo Bar Baz', $textdomain );
+
+        remove_filter( 'locale', array( $this, '_filter_locale_count' ) );
+
+        $this->assertFalse( is_textdomain_loaded( $textdomain ) );
+        $this->assertSame( 1, $this->locale_count );
+    }
+
+    public function _filter_locale_count( $locale ) {
+        ++$this->locale_count;
+
+        return $locale;
+    }
 }