Changeset 39347

Timestamp:

11/23/2016 01:37:12 PM (10 years ago)

Author:

swissspidy

Message:

Embeds: Correctly remove security attribute from iframes in IE 10 and IE 11.

This was originally added in 4.4, but presumably broke with [35708], which prevented these browsers from actually reaching the relevant code section.
Let's make embeds work again in IE 10 and IE 11.

Fixes #38694.

File:

• trunk/src/wp-includes/js/wp-embed.js (modified) (1 diff)

trunk/src/wp-includes/js/wp-embed.js

@@ -98 +98 @@
                         source = iframes[ i ];
 
-                        if ( source.getAttribute( 'data-secret' ) ) {
-                                continue;
+                        if ( ! source.getAttribute( 'data-secret' ) ) {
+                                /* Add secret to iframe */
+                                secret = Math.random().toString( 36 ).substr( 2, 10 );
+                                source.src += '#?secret=' + secret;
+                                source.setAttribute( 'data-secret', secret );
                         }
-
-                        /* Add secret to iframe */
-                        secret = Math.random().toString( 36 ).substr( 2, 10 );
-                        source.src += '#?secret=' + secret;
-                        source.setAttribute( 'data-secret', secret );
 
                         /* Remove security attribute from iframes in IE10 and IE11. */