Changeset 39353

Timestamp:

11/24/2016 12:07:50 AM (8 years ago)

Author:

joehoyle

Message:

REST API: Special case the “standard” post format to always be allowed.

Fixes #38916.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1909 +1909 @@
                         'description' => __( 'The format for the object.' ),
                         'type'        => 'string',
-                        'enum'        => $supports_formats ? array_values( $supports_formats[0] ) : array(),
+                        'enum'        => array_merge( array( 'standard' ), $supports_formats ? array_values( $supports_formats[0] ) : array() ),
                         'context'     => array( 'view', 'edit' ),
                     );

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -1288 +1288 @@
     }
 
+    public function test_create_post_with_standard_format() {
+        wp_set_current_user( self::$editor_id );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/posts' );
+        $params = $this->set_post_data( array(
+            'format' => 'standard',
+        ) );
+        $request->set_body_params( $params );
+        $response = $this->server->dispatch( $request );
+
+        $data = $response->get_data();
+        $new_post = get_post( $data['id'] );
+        $this->assertEquals( 'standard', $data['format'] );
+        $this->assertFalse( get_post_format( $new_post->ID ) );
+    }
+
     public function test_create_post_with_invalid_format() {
         wp_set_current_user( self::$editor_id );
@@ -1752 +1768 @@
         $this->assertEquals( 'gallery', $data['format'] );
         $this->assertEquals( 'gallery', get_post_format( $new_post->ID ) );
+    }
+
+    public function test_update_post_with_standard_format() {
+        wp_set_current_user( self::$editor_id );
+
+        $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+        $params = $this->set_post_data( array(
+            'format' => 'standard',
+        ) );
+        $request->set_body_params( $params );
+        $response = $this->server->dispatch( $request );
+
+        $data = $response->get_data();
+        $new_post = get_post( $data['id'] );
+        $this->assertEquals( 'standard', $data['format'] );
+        $this->assertFalse( get_post_format( $new_post->ID ) );
     }