Changeset 39371 for trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

Timestamp:

11/30/2016 03:02:01 AM (8 years ago)

Author:

jnylen0

Message:

REST API: Add tests for empty or "no-op" updates.

The API should allow updates that don't actually change anything. This allows
clients to, for example, accidentally send the same request twice without
encountering unexpected errors. This currently works for posts, terms, and
users, so this commit adds test cases accordingly.

See #38700 for issues preventing this from working for comments.

Fixes #38975.

File:

• trunk/tests/phpunit/tests/rest-api/rest-users-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -1086 +1086 @@
         // as per https://core.trac.wordpress.org/ticket/21429
         $this->assertEquals( $pw_before, $user->user_pass );
+    }
+
+    public function test_update_item_no_change() {
+        $this->allow_user_to_manage_multisite();
+        wp_set_current_user( self::$user );
+        $user = get_userdata( self::$editor );
+
+        $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/users/%d', self::$editor ) );
+        $request->set_param( 'slug', $user->user_nicename );
+
+        // Run twice to make sure that the update still succeeds even if no DB
+        // rows are updated.
+        $response = $this->server->dispatch( $request );
+        $this->assertEquals( 200, $response->get_status() );
+
+        $response = $this->server->dispatch( $request );
+        $this->assertEquals( 200, $response->get_status() );
     }